[issue45203] Improve specialization stats for LOAD_METHOD and BINARY_SUBSCR

2021-10-10 Thread Ken Jin
Ken Jin added the comment: I'm closing this as there doesn't seem to be anything left to do. Please do reopen this issue if you feel that isn't the case. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tra

[issue45203] Improve specialization stats for LOAD_METHOD and BINARY_SUBSCR

2021-09-17 Thread Ken Jin
Ken Jin added the comment: New changeset 4857e53890408fd5a8ee0e83c0250dd5355b3de3 by Ken Jin in branch 'main': bpo-45203: fix compiler warnings (GH-28357) https://github.com/python/cpython/commit/4857e53890408fd5a8ee0e83c0250dd5355b3de3 -- ___ Py

[issue45203] Improve specialization stats for LOAD_METHOD and BINARY_SUBSCR

2021-09-15 Thread Ken Jin
Change by Ken Jin : -- nosy: +kj nosy_count: 2.0 -> 3.0 pull_requests: +26771 pull_request: https://github.com/python/cpython/pull/28357 ___ Python tracker ___

[issue45203] Improve specialization stats for LOAD_METHOD and BINARY_SUBSCR

2021-09-15 Thread STINNER Victor
STINNER Victor added the comment: load_method_fail_kind() added by commit 11cdf2a6702639571554cbf3f69f57d688564540 introduced a compiler (GCC) warning: Python/specialize.c: In function 'load_method_fail_kind': Python/specialize.c:878:1: warning: control reaches end of non-void function [-Wre

[issue45203] Improve specialization stats for LOAD_METHOD and BINARY_SUBSCR

2021-09-15 Thread Mark Shannon
Mark Shannon added the comment: New changeset 11cdf2a6702639571554cbf3f69f57d688564540 by Mark Shannon in branch 'main': bpo-45203: Cleanup stats gathering code for LOAD_METHOD (GH-28352) https://github.com/python/cpython/commit/11cdf2a6702639571554cbf3f69f57d688564540 -- _

[issue45203] Improve specialization stats for LOAD_METHOD and BINARY_SUBSCR

2021-09-15 Thread Mark Shannon
Change by Mark Shannon : -- keywords: +patch pull_requests: +26766 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28352 ___ Python tracker ___ ___

[issue45203] Improve specialization stats for LOAD_METHOD and BINARY_SUBSCR

2021-09-15 Thread Mark Shannon
New submission from Mark Shannon : The stats for BINARY_SUBSCR and to a lesser amount LOAD_METHOD don't tell us much about what isn't being specialized. We should refine the stats to give us a better idea of what to optimize for. -- assignee: Mark.Shannon components: Interpreter Core