[issue45188] De-couple the Windows builds from freezing modules.

Change by Eric Snow : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Pyt

[issue45188] De-couple the Windows builds from freezing modules.

Guido van Rossum added the comment: We can once GH-28375 lands. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue45188] De-couple the Windows builds from freezing modules.

Eric Snow added the comment: Can we close this? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue45188] De-couple the Windows builds from freezing modules.

Eric Snow added the comment: FYI, I have a PR up for dropping the .h files: https://github.com/python/cpython/pull/28375. -- ___ Python tracker ___ __

[issue45188] De-couple the Windows builds from freezing modules.

Guido van Rossum added the comment: I tried this: - remove the generated .h files - touched dictobject.c - touched dictobject.h After each step I tried to rebuild. Each case the compilation of frozen.c failed and then the build stopped, so apparently the .h files weren't generated early eno

[issue45188] De-couple the Windows builds from freezing modules.

Steve Dower added the comment: Should be able to, yeah. Though I didn't test that. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue45188] De-couple the Windows builds from freezing modules.

Guido van Rossum added the comment: Is this now done? I.e. can we now drop the frozen .h files from the repo? -- nosy: +gvanrossum ___ Python tracker ___ _

[issue45188] De-couple the Windows builds from freezing modules.

Steve Dower added the comment: New changeset 09b4ad11f323f8702cde795e345b75e0fbb1a9a5 by Steve Dower in branch 'main': bpo-45188: Windows now regenerates frozen modules at the start of build instead of late (GH-28322) https://github.com/python/cpython/commit/09b4ad11f323f8702cde795e345b75e0f

[issue45188] De-couple the Windows builds from freezing modules.

Eric Snow added the comment: New changeset cbeb81971057d6c382f45ecce92df2b204d4106a by Eric Snow in branch 'main': bpo-45020: Freeze some of the modules imported during startup. (gh-28335) https://github.com/python/cpython/commit/cbeb81971057d6c382f45ecce92df2b204d4106a --

[issue45188] De-couple the Windows builds from freezing modules.

Change by Eric Snow : -- pull_requests: +26747 pull_request: https://github.com/python/cpython/pull/28335 ___ Python tracker ___ ___

[issue45188] De-couple the Windows builds from freezing modules.

Change by Steve Dower : -- keywords: +patch pull_requests: +26731 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/28322 ___ Python tracker _

[issue45188] De-couple the Windows builds from freezing modules.

Steve Dower added the comment: Only thing I'd add is that you should just be able to list the required .c files in _freeze_module.vcxproj (formerly known as freeze_importlib.vcxproj) rather than depending on pythoncore.vcxproj. That will generate twice as many .obj files for those modules (w

[issue45188] De-couple the Windows builds from freezing modules.

New submission from Eric Snow : Currently for Windows builds, generating the frozen modules depends on first building python.exe. One consequence of this is that we must keep all frozen module .h files in the repo (which we'd like to avoid for various reasons). We should be able to freeze mo