[issue45089] [sqlite3] the trace callback does not raise exceptions on error

Change by Erlend E. Aasland : -- resolution: wont fix -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45089] [sqlite3] the trace callback does not raise exceptions on error

Pablo Galindo Salgado added the comment: New changeset 6fc66d6b9d39fa7a5a8692062d54b5a6a1aa0283 by Pablo Galindo (Miss Islington (bot)) in branch '3.10': bpo-45089: Improve sqlite3 trace callback docs (GH-28238) (GH-28371) https://github.com/python/cpython/commit/6fc66d6b9d39fa7a5a8692062d54b

[issue45089] [sqlite3] the trace callback does not raise exceptions on error

Change by Łukasz Langa : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailin

[issue45089] [sqlite3] the trace callback does not raise exceptions on error

Łukasz Langa added the comment: Thanks, Erlend! ✨ 🍰 ✨ -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue45089] [sqlite3] the trace callback does not raise exceptions on error

Łukasz Langa added the comment: New changeset 97802a8edb3f15aef9ecc1cac97c4c1b4ed3fdfc by Miss Islington (bot) in branch '3.9': bpo-45089: Improve sqlite3 trace callback docs (GH-28238) (GH-28372) https://github.com/python/cpython/commit/97802a8edb3f15aef9ecc1cac97c4c1b4ed3fdfc -- _

[issue45089] [sqlite3] the trace callback does not raise exceptions on error

Łukasz Langa added the comment: New changeset 87f0ac8c1de83ac63447b9fe799dfb1657a5a9db by Miss Islington (bot) in branch '3.10': bpo-45089: Improve sqlite3 trace callback docs (GH-28238) (GH-28371) https://github.com/python/cpython/commit/87f0ac8c1de83ac63447b9fe799dfb1657a5a9db --

[issue45089] [sqlite3] the trace callback does not raise exceptions on error

Łukasz Langa added the comment: New changeset 51056b40e711d84692d099ac8970077b33c7fafd by Erlend Egeberg Aasland in branch 'main': bpo-45089: Improve sqlite3 trace callback docs (GH-28238) https://github.com/python/cpython/commit/51056b40e711d84692d099ac8970077b33c7fafd -- nosy: +luk

[issue45089] [sqlite3] the trace callback does not raise exceptions on error

Change by miss-islington : -- pull_requests: +26786 pull_request: https://github.com/python/cpython/pull/28372 ___ Python tracker ___ __

[issue45089] [sqlite3] the trace callback does not raise exceptions on error

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +26785 pull_request: https://github.com/python/cpython/pull/28371 ___ Python tracker _

[issue45089] [sqlite3] the trace callback does not raise exceptions on error

Change by Erlend E. Aasland : -- pull_requests: +26658 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/28238 ___ Python tracker ___ ___

[issue45089] [sqlite3] the trace callback does not raise exceptions on error

Erlend E. Aasland added the comment: > It *would* be possible to improve the documentation, though. +1 -- ___ Python tracker ___ _

[issue45089] [sqlite3] the trace callback does not raise exceptions on error

Petr Viktorin added the comment: It *would* be possible to improve the documentation, though. Say that it is only meant for debugging, document that exceptions are not propagated, and mention enable_callback_tracebacks. -- assignee: -> docs@python components: +Documentation nosy: +do

[issue45089] [sqlite3] the trace callback does not raise exceptions on error

Erlend E. Aasland added the comment: Quoting Petr from PR 28133: Without the ability to tell SQLite to abort on trace failure, I doubt we can do much better than the current behavior. Getting an exception and having the data inserted seems quite irregular. Closing this issue as won't fi

[issue45089] [sqlite3] the trace callback does not raise exceptions on error

Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +26571 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28133 ___ Python tracker __

[issue45089] [sqlite3] the trace callback does not raise exceptions on error

New submission from Erlend E. Aasland : Currently, two calls can raise exceptions in the _trace_callback() in Modules/_sqlite/connection.c: 1. PyUnicode_DecodeUTF8() can raise an exception 2. PyObject_CallOneArg() — calling the user callback — can raise an exception Currently, we either Py