[issue44856] Possible reference leak in error paths of update_bases() and __build_class__

Łukasz Langa added the comment: Confirmed this fixed refleaks in test_typing. Backported to all branches listed on the issue. Thanks for super-effective debugging and the fix, Pablo! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed _

[issue44856] Possible reference leak in error paths of update_bases() and __build_class__

miss-islington added the comment: New changeset ac8f72cd3ffa24f53c558911947c42316865683c by Miss Islington (bot) in branch '3.10': bpo-44856: Possible reference leak in error paths of update_bases() and __build_class__ (GH-27647) https://github.com/python/cpython/commit/ac8f72cd3ffa24f53c558

[issue44856] Possible reference leak in error paths of update_bases() and __build_class__

Łukasz Langa added the comment: New changeset 0a423096e8d8bbe22c0fb0904f7520387a8d4247 by Miss Islington (bot) in branch '3.8': bpo-44856: Possible reference leak in error paths of update_bases() and __build_class__ (GH-27647) (GH-27652) https://github.com/python/cpython/commit/0a423096e8d8bb

[issue44856] Possible reference leak in error paths of update_bases() and __build_class__

Łukasz Langa added the comment: New changeset ed718e9b07df06ea1abbe7b34c649e9d610adf86 by Miss Islington (bot) in branch '3.9': bpo-44856: Possible reference leak in error paths of update_bases() and __build_class__ (GH-27647) (GH-27651) https://github.com/python/cpython/commit/ed718e9b07df06

[issue44856] Possible reference leak in error paths of update_bases() and __build_class__

Change by miss-islington : -- pull_requests: +26147 pull_request: https://github.com/python/cpython/pull/27653 ___ Python tracker ___ __

[issue44856] Possible reference leak in error paths of update_bases() and __build_class__

Łukasz Langa added the comment: New changeset a40675c659cd8c0699f85ee9ac31660f93f8c2f5 by Pablo Galindo Salgado in branch 'main': bpo-44856: Possible reference leak in error paths of update_bases() and __build_class__ (GH-27647) https://github.com/python/cpython/commit/a40675c659cd8c0699f85ee

[issue44856] Possible reference leak in error paths of update_bases() and __build_class__

Change by miss-islington : -- pull_requests: +26146 pull_request: https://github.com/python/cpython/pull/27652 ___ Python tracker ___ __

[issue44856] Possible reference leak in error paths of update_bases() and __build_class__

Change by miss-islington : -- nosy: +miss-islington nosy_count: 1.0 -> 2.0 pull_requests: +26145 pull_request: https://github.com/python/cpython/pull/27651 ___ Python tracker _

[issue44856] Possible reference leak in error paths of update_bases() and __build_class__

Change by Pablo Galindo Salgado : -- title: Possible reference leak in error paths of update_bases() -> Possible reference leak in error paths of update_bases() and __build_class__ ___ Python tracker ___

[issue44856] Possible reference leak in error paths of update_bases()

Pablo Galindo Salgado added the comment: Oh, damn, turns out that there is a ton of reference leaks in the error path of __build_class__ as well. These leaks have been since forever! Curiously I found about them when debugging https://bugs.python.org/issue44524 -- _

[issue44856] Possible reference leak in error paths of update_bases()

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +26141 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27647 ___ Python tracker __

[issue44856] Possible reference leak in error paths of update_bases()

Change by Pablo Galindo Salgado : -- versions: +Python 3.10, Python 3.8, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mail

[issue44856] Possible reference leak in error paths of update_bases()

New submission from Pablo Galindo Salgado : Here: https://github.com/python/cpython/blob/17c23167942498296f0bdfffe52e72d53d66d693/Python/bltinmodule.c#L60-L88 Seems that new_base is not properly cleaned on the error paths -- messages: 399161 nosy: pablogsal priority: normal severity:

[issue44856] Possible reference leak in error paths of update_bases()

Change by Pablo Galindo Salgado : -- versions: +Python 3.11 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h