[issue44520] exception is thrown if bs = None

2021-06-28 Thread Irit Katriel
Irit Katriel added the comment: Right, so the question is whether it is correct that "an empty string needs to be returned in this case". Adding orsenthil to answer that as the module's expert. Also, your patch would need a unit test. -- nosy: +orsenthil ___

[issue44520] exception is thrown if bs = None

2021-06-28 Thread Олег Масло
Олег Масло added the comment: Irit, the problem is that if you pass the bs parameter equal to None to the quote_from_bytes function, then the bs parameter will not be checked for existence, because a TypeError exception will be raised, and an empty string needs to be returned in this case. Th

[issue44520] exception is thrown if bs = None

2021-06-28 Thread Irit Katriel
Irit Katriel added the comment: Please describe the problem you would like to see fixed, rather than the code change you would like to make. -- ___ Python tracker ___ ___

[issue44520] exception is thrown if bs = None

2021-06-28 Thread Irit Katriel
Irit Katriel added the comment: Crash is typically a segfault, not an exception. -- nosy: +iritkatriel type: crash -> behavior ___ Python tracker ___ _

[issue44520] exception is thrown if bs = None

2021-06-28 Thread Олег Масло
New submission from Олег Масло : need moved the check parameter to the top of the isnstance check, because if bs = None then an exception is thrown -- components: Library (Lib) messages: 396617 nosy: asicscwcs priority: normal pull_requests: 25500 severity: normal status: open title: ex