[issue44479] Windows build doesn't regenerate some files

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue44479] Windows build doesn't regenerate some files

Steve Dower added the comment: New changeset 0b984d19547c2c16203e9ab2b2959fbabcde by Steve Dower in branch '3.10': bpo-44479: Do not regenerate files during a PGO build as it will invalidate the profile. (GH-27462) https://github.com/python/cpython/commit/0b984d19547c2c16203e9ab2b295

[issue44479] Windows build doesn't regenerate some files

Change by Steve Dower : -- pull_requests: +25985 pull_request: https://github.com/python/cpython/pull/27462 ___ Python tracker ___ _

[issue44479] Windows build doesn't regenerate some files

Steve Dower added the comment: New changeset 3edec5d142365f2340865b4f12652e6aa627818a by Steve Dower in branch 'main': bpo-44479: Do not regenerate files during a PGO build as it will invalidate the profile. (GH-27460) https://github.com/python/cpython/commit/3edec5d142365f2340865b4f12652e6a

[issue44479] Windows build doesn't regenerate some files

Change by Steve Dower : -- pull_requests: +25983 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/27460 ___ Python tracker ___ _

[issue44479] Windows build doesn't regenerate some files

Steve Dower added the comment: > Would it be OK to run python in externals folder instead ? No, because it needs to freeze with the current build. However, we should definitely not regenerate anything when "$(Configuration) == 'PGUpdate'". Checking that in regen.targets should prevent the is

[issue44479] Windows build doesn't regenerate some files

neonene added the comment: When building, some pull-requests invoke regeneration of test_frozenmain.h. On PGO mode, MSVC tries to call instrumented python and stops with "pgort140.dll not found" error. Would it be OK to run python in externals folder instead ? --

[issue44479] Windows build doesn't regenerate some files

Change by neonene : -- nosy: +neonene nosy_count: 7.0 -> 8.0 pull_requests: +25688 pull_request: https://github.com/python/cpython/pull/27146 ___ Python tracker ___ ___

[issue44479] Windows build doesn't regenerate some files

Steve Dower added the comment: New changeset f2491c647937fc0871a473c19e3d5cb5392cfca0 by Steve Dower in branch '3.10': bpo-44479: Simplified LICENSE.txt regeneration in Windows build (GH-27056) https://github.com/python/cpython/commit/f2491c647937fc0871a473c19e3d5cb5392cfca0 -- ___

[issue44479] Windows build doesn't regenerate some files

Change by Steve Dower : -- pull_requests: +25613 pull_request: https://github.com/python/cpython/pull/27058 ___ Python tracker ___ _

[issue44479] Windows build doesn't regenerate some files

Steve Dower added the comment: New changeset 3d3027c5fcc683c14ee55ad231d79971ba12b24d by Steve Dower in branch 'main': bpo-44479: Simplified LICENSE.txt regeneration in Windows build (GH-27056) https://github.com/python/cpython/commit/3d3027c5fcc683c14ee55ad231d79971ba12b24d -- ___

[issue44479] Windows build doesn't regenerate some files

Change by Steve Dower : -- pull_requests: +25612 pull_request: https://github.com/python/cpython/pull/27056 ___ Python tracker ___ _

[issue44479] Windows build doesn't regenerate some files

Steve Dower added the comment: Didn't even realise we had a test for it. Maybe it only runs in install-like layouts? I'll simplify the regeneration by just doing it every time. Nothing else depends on the license file, so it won't matter if we touch it unnecessarily. -- ___

[issue44479] Windows build doesn't regenerate some files

Ken Jin added the comment: @Steve, after this change, the Azure Pipelines commit CI's appx tests started failing on main and 3.10. https://dev.azure.com/Python/cpython/_build/results?buildId=83619&view=results == FAIL: test_

[issue44479] Windows build doesn't regenerate some files

Steve Dower added the comment: Great! I backported to 3.10, but we never took the other changes back to 3.9 so it can stop there. -- assignee: -> steve.dower resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.11

[issue44479] Windows build doesn't regenerate some files

Steve Dower added the comment: New changeset f3289a50503ed1a809d77fb03744bdcc7b9f1093 by Steve Dower in branch '3.10': bpo-44479: Regenerate test_frozenmain.h and frozen_hello.h during build on Windows (GH-26984) https://github.com/python/cpython/commit/f3289a50503ed1a809d77fb03744bdcc7b9f10

[issue44479] Windows build doesn't regenerate some files

Guido van Rossum added the comment: Thanks, I tried this and it works beautifully! -- ___ Python tracker ___ ___ Python-bugs-list m

[issue44479] Windows build doesn't regenerate some files

Change by Steve Dower : -- pull_requests: +25595 pull_request: https://github.com/python/cpython/pull/27035 ___ Python tracker ___ _

[issue44479] Windows build doesn't regenerate some files

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +25594 pull_request: https://github.com/python/cpython/pull/27034 ___ Python tracker _

[issue44479] Windows build doesn't regenerate some files

Steve Dower added the comment: New changeset 1b133ab8412e4f6a53914212df7a7656f376256d by Steve Dower in branch 'main': bpo-44479: Regenerate test_frozenmain.h and frozen_hello.h during build on Windows (GH-26984) https://github.com/python/cpython/commit/1b133ab8412e4f6a53914212df7a7656f37625

[issue44479] Windows build doesn't regenerate some files

Change by Steve Dower : -- keywords: +patch pull_requests: +25546 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26984 ___ Python tracker ___

[issue44479] Windows build doesn't regenerate some files

New submission from Guido van Rossum : The new PCbuild\build.bat script is much better at regenerating necessary files. However I just found out that there are some more files that need to be regenerated occasionally: - Programs/test_frozenmain.h - Python/frozen_hello.h Could you add rules f

[issue44479] Windows build doesn't regenerate some files

Change by Guido van Rossum : -- components: Windows nosy: gvanrossum, paul.moore, steve.dower, tim.golden, zach.ware priority: normal severity: normal status: open title: Windows build doesn't regenerate some files ___ Python tracker