[issue4367] segmentation fault in ast_for_atom

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- resolution: accepted -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue4367] segmentation fault in ast_for_atom

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: On Fri, Nov 21, 2008 at 4:21 PM, Amaury Forgeot d'Arc <[EMAIL PROTECTED]> wrote: > > Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: > > Everything looks good. Thanks for the review. Fixed in r67320. > > (20 lines of a complex

[issue4367] segmentation fault in ast_for_atom

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Everything looks good. (20 lines of a complex test for two simple lines of code that nobody will ever run... unit tests is a religion) -- keywords: -needs review resolution: -> accepted _

[issue4367] segmentation fault in ast_for_atom

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: This new patch address review issues. Added file: http://bugs.python.org/file12102/use_PyObject_Str_and_test3.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue4367] segmentation fault in ast_for_atom

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Yes, it's better to simply call str() on the exception. I was confused by the fact that UnicodeError is a simple exception, with a single message, unlike UnicodeDecodeError which has more attributes. About the patch: - The test does not

[issue4367] segmentation fault in ast_for_atom

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- title: Patch for segmentation fault in ast_for_atom -> segmentation fault in ast_for_atom Added file: http://bugs.python.org/file12088/use_PyObject_Str_and_test2.patch ___ Python tracker <[EMAIL PR