[issue4323] Wrong encoding in files saved from IDLE (3.0rc2 on Windows)

2008-12-29 Thread Martin v. Löwis
Martin v. Löwis added the comment: Thanks for the review. Committed (with the proposed change) as r68022 and r68023. -- resolution: -> fixed status: open -> closed ___ Python tracker __

[issue4323] Wrong encoding in files saved from IDLE (3.0rc2 on Windows)

2008-11-21 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: The patch is good and does simplify things: the py3k conversion to unicode may have some advantages sometimes! I suggest to also remove the remaining two occurrences of "frameEncoding" in configDialog.py. This will suppress the extra

[issue4323] Wrong encoding in files saved from IDLE (3.0rc2 on Windows)

2008-11-19 Thread Martin v. Löwis
Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Here is a patch that removes the entire IDLE coding option machinery, thus implementing PEP 3120. -- keywords: +needs review Added file: http://bugs.python.org/file12060/remove_coding_option.py __

[issue4323] Wrong encoding in files saved from IDLE (3.0rc2 on Windows)

2008-11-14 Thread Martin v. Löwis
Martin v. Löwis <[EMAIL PROTECTED]> added the comment: The entire dialog should go away. The default source encoding is UTF-8 in Python 3.0, and IDLE should know that. The locale's encoding shouldn't ever be considered. -- nosy: +loewis ___ Python tra

[issue4323] Wrong encoding in files saved from IDLE (3.0rc2 on Windows)

2008-11-14 Thread STINNER Victor
STINNER Victor <[EMAIL PROTECTED]> added the comment: Implementation of the second solution: replace Ok button by a Cancel button. Escape key is Cancel, whereas Return key is the default action: edit the file. -- keywords: +patch Added file: http://bugs.python.org/file12005/idle_coding

[issue4323] Wrong encoding in files saved from IDLE (3.0rc2 on Windows)

2008-11-14 Thread STINNER Victor
STINNER Victor <[EMAIL PROTECTED]> added the comment: Quick but ugly solution: force the #coding: header without asking the user for that. Added file: http://bugs.python.org/file12004/idle_remove_coding_dialog.py ___ Python tracker <[EMAIL PROTECTED]>

[issue4323] Wrong encoding in files saved from IDLE (3.0rc2 on Windows)

2008-11-14 Thread STINNER Victor
STINNER Victor <[EMAIL PROTECTED]> added the comment: > If accepted, the file is saved with the wrong encoding "accept" means click on the "OK" button. You have to click on the biggest button "Edit my file" to create a valid file. The problem here is the text in the dialog but also the possibi

[issue4323] Wrong encoding in files saved from IDLE (3.0rc2 on Windows)

2008-11-14 Thread André
New submission from André <[EMAIL PROTECTED]>: When saving a source file with non-ascii characters from an IDLE window, on Windows platform (XP and Server 2003 at least) with locale English US locale.getdefaultlocale() ('en_US', 'cp1252') IDLE prompts in IOBinding.py with the message "no