[issue42773] build.yml workflow not testing on pushes

Change by Ammar Askar : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue42773] build.yml workflow not testing on pushes

miss-islington added the comment: New changeset 0898dcb3a0400d3c93e27f9feb4c2207eb1a996d by Miss Islington (bot) in branch '3.9': bpo-42773: fix tests not being run on pushes (GH-24004) https://github.com/python/cpython/commit/0898dcb3a0400d3c93e27f9feb4c2207eb1a996d -- ___

[issue42773] build.yml workflow not testing on pushes

miss-islington added the comment: New changeset d29dbb122d8b8ee22b2d826af4d234a2c2cf7ba2 by Miss Islington (bot) in branch '3.8': bpo-42773: fix tests not being run on pushes (GH-24004) https://github.com/python/cpython/commit/d29dbb122d8b8ee22b2d826af4d234a2c2cf7ba2 -- ___

[issue42773] build.yml workflow not testing on pushes

Change by miss-islington : -- pull_requests: +23246 pull_request: https://github.com/python/cpython/pull/24438 ___ Python tracker ___ __

[issue42773] build.yml workflow not testing on pushes

Change by miss-islington : -- pull_requests: +23245 pull_request: https://github.com/python/cpython/pull/24437 ___ Python tracker ___ __

[issue42773] build.yml workflow not testing on pushes

Change by miss-islington : -- pull_requests: +22852 pull_request: https://github.com/python/cpython/pull/24010 ___ Python tracker ___ __

[issue42773] build.yml workflow not testing on pushes

Change by miss-islington : -- pull_requests: +22853 pull_request: https://github.com/python/cpython/pull/24011 ___ Python tracker ___ __

[issue42773] build.yml workflow not testing on pushes

Ammar Askar added the comment: Thank you Filipe and Mariatta, the fix looks good to me. I think it needs a backport to the 3.9 branch though. -- ___ Python tracker ___ __

[issue42773] build.yml workflow not testing on pushes

Filipe Laíns added the comment: Ammar, could you confirm the issue is now solved? -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue42773] build.yml workflow not testing on pushes

miss-islington added the comment: New changeset 4ac923f2756f835f512339ee181348cc535ab07f by Filipe Laíns in branch 'master': bpo-42773: fix tests not being run on pushes (GH-24004) https://github.com/python/cpython/commit/4ac923f2756f835f512339ee181348cc535ab07f -- nosy: +miss-isling

[issue42773] build.yml workflow not testing on pushes

Filipe Laíns added the comment: This is due to a typo, I commented on the original PR and opened a PR fixing it. Cheers :) -- ___ Python tracker ___ __

[issue42773] build.yml workflow not testing on pushes

Change by Filipe Laíns : -- keywords: +patch pull_requests: +22846 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24004 ___ Python tracker ___

[issue42773] build.yml workflow not testing on pushes

Ammar Askar added the comment: Any commit that gets to pushed to the master, 3.9, 3.8 and 3.7 branches. e.g all the commits here https://github.com/python/cpython/commits/master, they end up failing the "Check for source changes" step and skipping even when there's non-documentation changes.

[issue42773] build.yml workflow not testing on pushes

STINNER Victor added the comment: > build.yml workflow not testing on pushes What does it mean: "on pushes"? -- ___ Python tracker ___ ___

[issue42773] build.yml workflow not testing on pushes

New submission from Ammar Askar : It looks like on pushes to Github, we currently aren't running tests. (Though this isn't too big of a concern since they get run on pull requests). Here's an example of a recent run https://github.com/python/cpython/runs/1609911031 ``` fatal: ambiguous argum