[issue42431] Fix outdated bytes comments

2020-12-03 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue42431] Fix outdated bytes comments

2020-12-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 2ad93821a69e6efac3b0efe1d205d6e5ef030791 by Serhiy Storchaka in branch 'master': bpo-42431: Fix outdated bytes comments (GH-23458) https://github.com/python/cpython/commit/2ad93821a69e6efac3b0efe1d205d6e5ef030791 --

[issue42431] Fix outdated bytes comments

2020-11-23 Thread STINNER Victor
STINNER Victor added the comment: (Sorry, I need more coffee. New attempt.) A C extension must define Py_BUILD_CORE macro or variant to include such header file. There is no intent to technically prevent to include a header file, only an intent to warn users that they should not do that unle

[issue42431] Fix outdated bytes comments

2020-11-23 Thread STINNER Victor
STINNER Victor added the comment: > Is it true that headers in Include/internal are more private than headers in > Include/cpython? It is not clear from names. You cannot include an header file from Include/internal by default. All internal header files are guarded with: #ifndef Py_BUILD_CO

[issue42431] Fix outdated bytes comments

2020-11-22 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +22350 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23458 ___ Python tracker ___

[issue42431] Fix outdated bytes comments

2020-11-22 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Some comments in C code still refer to bytearray object as bytes object and to bytes object as string object. The proposed PR fixes outdated comments. It also moves the definition of macros F_LJUST etc from public header to private header. They are only