[issue41966] datetime.time issue with pickling in PyPy

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41966] datetime.time issue with pickling in PyPy

Serhiy Storchaka added the comment: New changeset 1040299e9283609f3de0f6e32a0d43458fe7f4f6 by Miss Skeleton (bot) in branch '3.8': bpo-41966: Fix pickling pure datetime.time subclasses (GH-22731) (GH-22748) https://github.com/python/cpython/commit/1040299e9283609f3de0f6e32a0d43458fe7f4f6 --

[issue41966] datetime.time issue with pickling in PyPy

Serhiy Storchaka added the comment: New changeset a055ced9d43630cadc3c1d5edab0884f2c5131ea by Miss Skeleton (bot) in branch '3.9': bpo-41966: Fix pickling pure datetime.time subclasses (GH-22731) (GH-22747) https://github.com/python/cpython/commit/a055ced9d43630cadc3c1d5edab0884f2c5131ea --

[issue41966] datetime.time issue with pickling in PyPy

Change by miss-islington : -- pull_requests: +21711 pull_request: https://github.com/python/cpython/pull/22748 ___ Python tracker ___ __

[issue41966] datetime.time issue with pickling in PyPy

Serhiy Storchaka added the comment: New changeset c304c9a7efa8751b5bc7526fa95cd5f30aac2b92 by scaramallion in branch 'master': bpo-41966: Fix pickling pure datetime.time subclasses (GH-22731) https://github.com/python/cpython/commit/c304c9a7efa8751b5bc7526fa95cd5f30aac2b92 -- _

[issue41966] datetime.time issue with pickling in PyPy

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +21710 pull_request: https://github.com/python/cpython/pull/22747 ___ Python tracker _

[issue41966] datetime.time issue with pickling in PyPy

Change by Dean : -- keywords: +patch pull_requests: +21695 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22731 ___ Python tracker ___ ___

[issue41966] datetime.time issue with pickling in PyPy

Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka versions: -Python 3.5, Python 3.6, Python 3.7 ___ Python tracker ___ ___ Py

[issue41966] datetime.time issue with pickling in PyPy

Dean added the comment: Code demonstrating the issue; the CTimeFoo class is pickled correctly, but TimeFoo isn't. import builtins from _datetime import time as ctime original_importer = builtins.__import__ def my_importer(name, globals, locals, fromlist, level): if name == '_datetime':

[issue41966] datetime.time issue with pickling in PyPy

New submission from Dean : I've run into an issue pickling a datetime.time subclass in PyPy3. I believe it arises because PyPy uses the pure Python implementation of time and time.__reduce_ex__() returns (time, ...) on this line (https://github.com/python/cpython/blob/044a1048ca93d466965afc02