[issue41343] Convert complex methods to Argument Clinic

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41343] Convert complex methods to Argument Clinic

Serhiy Storchaka added the comment: New changeset e123012d79121ab543583631bb84c7fc27d06338 by Dong-hee Na in branch 'master': bpo-41343: Convert methods of complex to Argument Clinic (GH-21550) https://github.com/python/cpython/commit/e123012d79121ab543583631bb84c7fc27d06338 -- ___

[issue41343] Convert complex methods to Argument Clinic

Dong-hee Na added the comment: Hmm, I re-ran all the benchmark. - conjugate => It looks like noise. - __getnewargs__ -> consistently showing performance improvement. (2-3%) FYI, I ran benchmarks on the macOS. -- ___ Python tracker

[issue41343] Convert complex methods to Argument Clinic

Dong-hee Na added the comment: > But I am surprised that you get a difference for conjugate() and > __getnewargs__. It could be a noise :) -- ___ Python tracker ___ ___

[issue41343] Convert complex methods to Argument Clinic

Serhiy Storchaka added the comment: I wrote similar patch for __format__ and got similar tiny speed up. It is expectable. But I am surprised that you get a difference for conjugate() and __getnewargs__. It may be a compiler artifact. In any case the benefit of converting to Argument Clinic i

[issue41343] Convert complex methods to Argument Clinic

Change by Dong-hee Na : -- keywords: +patch pull_requests: +20692 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21550 ___ Python tracker ___

[issue41343] Convert complex methods to Argument Clinic

Change by Dong-hee Na : -- assignee: -> corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue41343] Convert complex methods to Argument Clinic

New submission from Dong-hee Na : Mean +- std dev: [master_format] 3.54 us +- 0.06 us -> [clinic_format] 3.29 us +- 0.07 us: 1.08x faster (-7%) Mean +- std dev: [master_conjugate] 3.56 us +- 0.09 us -> [clinic_conjugate] 3.32 us +- 0.06 us: 1.07x faster (-7%) Mean +- std dev: [master__getnew