[issue41242] When concating strings, I think it is better to use += than join the list

2020-07-08 Thread Wansoo Kim
Wansoo Kim added the comment: Well... to be honest, I'm a little confused. bpo-41244 and this issue are completely opposite. I'm not used to Python community yet because it hasn't been long since I joined it. You're saying that if a particular method is not dramatically good, we prefer to k

[issue41242] When concating strings, I think it is better to use += than join the list

2020-07-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: In this particular case the number of concatenations is limited, the resulting string is usually short, and the code is not performance critical (it is the __repr__ implementation). So there is no significant advantage of one way over other, and no way is

[issue41242] When concating strings, I think it is better to use += than join the list

2020-07-08 Thread Andrew Svetlov
Andrew Svetlov added the comment: Remi is correct. Closing the issue. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue41242] When concating strings, I think it is better to use += than join the list

2020-07-08 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> wont fix stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue41242] When concating strings, I think it is better to use += than join the list

2020-07-08 Thread Rémi Lapeyre
Rémi Lapeyre added the comment: Hi Wansoo, using += instead of str.join() is less performant. Concatenating n strings with + will create and allocate n new strings will str.join() will carefully look ahead and allocate the correct amount of memory and do all concatenation at one: ➜ ~ pytho

[issue41242] When concating strings, I think it is better to use += than join the list

2020-07-08 Thread Wansoo Kim
Change by Wansoo Kim : -- keywords: +patch pull_requests: +20545 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21397 ___ Python tracker ___ _

[issue41242] When concating strings, I think it is better to use += than join the list

2020-07-08 Thread Wansoo Kim
New submission from Wansoo Kim : Hello I think it's better to use += than list.join() when concating strings. This is more intuitive than other methods. Also, I personally think it is not good for one variable to change to another type during runtime. https://github.com/python/cpython/blob/