[issue40925] Remove redundant macros used for stack manipulation in interpreter

Mark Shannon added the comment: Dennis, thanks for doing the benchmarking. You seem to have removed rather more macros than I suggested, but it probably won't make much difference to the results. Since this may have a negative effect on performance and doesn't seem to be popular, let's drop i

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Change by Mark Shannon : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list maili

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Terry J. Reedy added the comment: I could understand wanting to replace TOP,...,FOURTH with PEEK(n) and the SET_XYZs with the now deleted SET(_VALUE)(n, v), but to me, replacing PEEK-SET with POPs and PUSHes (in different orders) that directly mean something different but that compilers (all

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Change by hai shi : -- nosy: +shihai1991 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Raymond Hettinger added the comment: I don't see any advantage to making this change. The current code is readable and the macros have an obvious interpretation. We also know that they generate clean code on every compiler we've come across and on 32 bits. Also, this should be marked as ty

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Change by Dennis Sweeney : Removed file: https://bugs.python.org/file49229/master_perf.txt ___ Python tracker ___ ___ Python-bugs-list maili

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Change by Dennis Sweeney : Removed file: https://bugs.python.org/file49228/pushpop_perf.txt ___ Python tracker ___ ___ Python-bugs-list mail

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Change by Dennis Sweeney : Added file: https://bugs.python.org/file49230/perf_diff.txt ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Dennis Sweeney added the comment: I just added PR 20845, but I'm concerned about performance. I'm attaching the results of a run of pyperformance before and after PR 20845. -- Added file: https://bugs.python.org/file49228/pushpop_perf.txt ___ Pytho

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Change by Dennis Sweeney : Added file: https://bugs.python.org/file49229/master_perf.txt ___ Python tracker ___ ___ Python-bugs-list mailing

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Change by Dennis Sweeney : -- nosy: +Dennis Sweeney nosy_count: 3.0 -> 4.0 pull_requests: +20038 pull_request: https://github.com/python/cpython/pull/20845 ___ Python tracker _

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Mark Shannon added the comment: New changeset 33faf5c4f43e24766cf567bec89ad4c7f1491ff7 by Dong-hee Na in branch 'master': bpo-40925: Remove unused stack macro SET_VALUE (GH-20783) https://github.com/python/cpython/commit/33faf5c4f43e24766cf567bec89ad4c7f1491ff7 -- _

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Change by Dong-hee Na : -- keywords: +patch pull_requests: +19979 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/20783 ___ Python tracker _

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Dong-hee Na added the comment: AFAIK, SET_VALUE is not used in CPython master codebase. -- ___ Python tracker ___ ___ Python-bugs-l

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Mark Shannon added the comment: I'm proposing that we remove the nine macros above; the eleven listed, except TOP() and SECOND(). They can be replaced by POP(), PUSH() and PEEK() without lost of functionality or performance. -- ___ Python tracker

[issue40925] Remove redundant macros used for stack manipulation in interpreter

Eric V. Smith added the comment: What type of changes are you proposing to make? -- nosy: +eric.smith ___ Python tracker ___ ___ Py

[issue40925] Remove redundant macros used for stack manipulation in interpreter

New submission from Mark Shannon : Currently, there are fourteen macros provided for stack manipulation. Along with the fundamental, POP(), PUSH() and PEEK(n) the following eleven are also provided: TOP() SECOND() THIRD() FOURTH() SET_TOP(v) SET_SECOND(v)