[issue40458] test_bad_getattr crashes on APPX test

Change by Steve Dower : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue40458] test_bad_getattr crashes on APPX test

miss-islington added the comment: New changeset a6a116c1b964b3d1fdff0f533861ed2a2227de1f by Miss Islington (bot) in branch '3.8': bpo-40458: Increase reserved stack space to prevent overflow crash on Windows (GH-19845) https://github.com/python/cpython/commit/a6a116c1b964b3d1fdff0f533861ed2a

[issue40458] test_bad_getattr crashes on APPX test

Steve Dower added the comment: Merged without the improved diagnostics. I might add that later if I get time. Łukasz - this is a fairly trivial crash fix that'd be nice (and safe) to pull into 3.8.3, but not critical. Your call. -- assignee: -> steve.dower nosy: +lukasz.langa stage:

[issue40458] test_bad_getattr crashes on APPX test

Steve Dower added the comment: New changeset ac4bf424119d1300f57929120968e216a85d3a25 by Steve Dower in branch 'master': bpo-40458: Increase reserved stack space to prevent overflow crash on Windows (GH-19845) https://github.com/python/cpython/commit/ac4bf424119d1300f57929120968e216a85d3a25

[issue40458] test_bad_getattr crashes on APPX test

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +19255 pull_request: https://github.com/python/cpython/pull/19941 ___ Python tracker _

[issue40458] test_bad_getattr crashes on APPX test

Steve Dower added the comment: Yeah, I already got that part. If you check the PR, I added some better diagnostics to faulthandler for this case, but I don't see where I can add it for other platforms? -- ___ Python tracker

[issue40458] test_bad_getattr crashes on APPX test

STINNER Victor added the comment: > Also, it was really test_bad_getattr that was crashing. Ah, an old friend. It seems like an issue with the maximum stack size. Here are my notes: https://pythondev.readthedocs.io/unstable_tests.html#unlimited-recursion Either reduce Python maximum stack de

[issue40458] test_bad_getattr crashes on APPX test

Steve Dower added the comment: Also, it was really test_bad_getattr that was crashing. -- title: test_attribute_name_interning crashes on APPX test -> test_bad_getattr crashes on APPX test ___ Python tracker __