[issue40385] Tools/checkpyc.py has been broken since PEP 552

2020-04-24 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset f82807746d26b4c047f7f3115065f20bb63fb5ff by Ammar Askar in branch 'master': closes bpo-40385: Remove Tools/scripts/checkpyc.py (GH-19709) https://github.com/python/cpython/commit/f82807746d26b4c047f7f3115065f20bb63fb5ff -- resolutio

[issue40385] Tools/checkpyc.py has been broken since PEP 552

2020-04-24 Thread Ammar Askar
Change by Ammar Askar : -- keywords: +patch pull_requests: +19030 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19709 ___ Python tracker ___

[issue40385] Tools/checkpyc.py has been broken since PEP 552

2020-04-24 Thread Benjamin Peterson
Benjamin Peterson added the comment: I'd vote for axing it. -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list

[issue40385] Tools/checkpyc.py has been broken since PEP 552

2020-04-24 Thread Ammar Askar
New submission from Ammar Askar : Looks like checkpyc.py has been broken since PEP 552 was implemented https://github.com/python/cpython/blob/0e80b561d442769631d66f1cc8813ac30f97378e/Tools/scripts/checkpyc.py#L44-L46 It fails to read the 4 bytes for the `flags` field nor does it handle hash b