[issue4036] Support bytes for subprocess.Popen()

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue4036] Support bytes for subprocess.Popen()

STINNER Victor added the comment: subprocess accepts byte string in program arguments in py3k, so the issue can be closed. I opened other issues for the other arguments: - current working directory: #8393 - environment variables: #8391 - error message: #8467 -- ___

[issue4036] Support bytes for subprocess.Popen()

Martin v. Löwis added the comment: On Windows, command lines shouldn't need to be encoded in any encoding. Instead, the unicode string should be passed to the system call as-is. -- ___ Python tracker _

[issue4036] Support bytes for subprocess.Popen()

Brian Curtin added the comment: The list2cmdline function checks spaces, tabs, etc in line 521 of subprocess.py. In your first test case, it ends up checking if a string is contained in a bytes object, which is a TypeError for the str not supporting the buffer API. Would it be acceptable to

[issue4036] Support bytes for subprocess.Popen()

STINNER Victor added the comment: Oops, I realized that the second test is just useless. The argument is str, not bytes. I wanted to test Popen(bytes, shell=True). What is the right encoding to convert a string to bytes for the file system? -- ___

[issue4036] Support bytes for subprocess.Popen()

STINNER Victor added the comment: os.exec*() now accept bytes thanks to the PEP 383: see issue #4035. I updated my patch: it now includes tests \o/ It works on Linux. Can someone test it on Windows and/or Mac OS X? -- resolution: -> fixed status: open -> closed Added file: http://bug

[issue4036] Support bytes for subprocess.Popen()

Changes by Daniel Diniz : -- components: +Library (Lib) priority: -> high type: -> feature request versions: +Python 3.1 -Python 3.0 ___ Python tracker ___ _

[issue4036] Support bytes for subprocess.Popen()

STINNER Victor <[EMAIL PROTECTED]> added the comment: @loewis: My patch only changes the behaviour of the POSIX version of subprocess, Windows version is unchanged. ___ Python tracker <[EMAIL PROTECTED]>

[issue4036] Support bytes for subprocess.Popen()

Changes by Toshio Kuratomi <[EMAIL PROTECTED]>: -- nosy: +a.badger ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list maili

[issue4036] Support bytes for subprocess.Popen()

STINNER Victor <[EMAIL PROTECTED]> added the comment: Oops, I attached the wrong patch :-/ -- dependencies: +Support bytes for os.exec*() Added file: http://bugs.python.org/file11742/subprocess-bytes.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue4036] Support bytes for subprocess.Popen()

Changes by STINNER Victor <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11696/os_exec_bytes.patch ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue4036] Support bytes for subprocess.Popen()

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: I think this should be deferred to 3.1. I'm not sure how much consistency across platforms is desirable, however, using strings is surely the better choice on Windows. I could sympathize with providing bytes support only on POSIX, but I'm sur

[issue4036] Support bytes for subprocess.Popen()

New submission from STINNER Victor <[EMAIL PROTECTED]>: subprocess doesn't support bytes for the "args" argument. - On Windows, subprocess._execute_child() converts args to a string if it was a list - On UNIX, subprocess._execute_child() converts args to a list if it's a string If shell=True