[issue3994] import fixer misses some symbols

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: I do have performance problems if I remove the match() override, but I found that special casing usage replacements fixes the bug while keeping speed. Done in r67390. Nick, thanks for the debugging and the patch! -- nosy: +benjami

[issue3994] import fixer misses some symbols

Nick Edds <[EMAIL PROTECTED]> added the comment: Here is a patch with a new test case. I don't know if we should apply it until we've heard from Collin though. The old version of fix_imports fails the new test, but this version, which allows matching of nodes nested within matches, passes the new

[issue3994] import fixer misses some symbols

Nick Edds <[EMAIL PROTECTED]> added the comment: The problem is that fix_imports doesn't look at matches that are nested within matches. So the _winreg.OpenKey part gets fixed, but the _winreg.HKEY_LOCAL_MACHINE does not because it is nested within the other node. I didn't make fix_imports so I d

[issue3994] import fixer misses some symbols

Nick Edds <[EMAIL PROTECTED]> added the comment: I'll look in to it. Just give me a couple of days. ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3994] import fixer misses some symbols

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- nosy: +nedds ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailin

[issue3994] import fixer misses some symbols

New submission from Mark Hammond <[EMAIL PROTECTED]>: The following source file: """ import _winreg _winreg.OpenKey(_winreg.HKEY_LOCAL_MACHINE, "foo") """ results in the following "patch": -import _winreg -_winreg.OpenKey(_winreg.HKEY_LOCAL_MACHINE, "foo") +import winreg +winreg.OpenKey(_winreg