[issue3954] _hotshot: invalid error control in logreader()

Amaury Forgeot d'Arc added the comment: Fixed in r67797 (trunk) and r67801 (2.6) hotshot was removed from py3k. -- resolution: accepted -> fixed status: open -> closed ___ Python tracker ___

[issue3954] _hotshot: invalid error control in logreader()

Changes by Amaury Forgeot d'Arc : -- assignee: -> amaury.forgeotdarc ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue3954] _hotshot: invalid error control in logreader()

STINNER Victor added the comment: > Regardless of the smiley, I certainly wouldn't object if you > requested permissions on python-dev... I still don't have an account and the issue is still open. 2.6(.1) and 3.0 are released. The patch has been reviewed by amaury.forgeotdarc, so can the patc

[issue3954] _hotshot: invalid error control in logreader()

Georg Brandl <[EMAIL PROTECTED]> added the comment: Regardless of the smiley, I certainly wouldn't object if you requested permissions on python-dev... ___ Python tracker <[EMAIL PROTECTED]> __

[issue3954] _hotshot: invalid error control in logreader()

STINNER Victor <[EMAIL PROTECTED]> added the comment: @georg: give me a svn access and i will commit it ;-) ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3954] _hotshot: invalid error control in logreader()

Georg Brandl <[EMAIL PROTECTED]> added the comment: Looks fine. Since it is minor, why not commit it now? -- nosy: +georg.brandl ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3954] _hotshot: invalid error control in logreader()

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: The patch is good to me. gotos are perfectly allowed for this purpose. (to python committers: Should this kind of "minor" issues be fixed after 2.6rc2? This could as well wait until 2.6.1) -- nosy: +amaury.forgeotdarc resoluti

[issue3954] _hotshot: invalid error control in logreader()

Changes by STINNER Victor <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11589/_hotshot_logreader.patch ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3954] _hotshot: invalid error control in logreader()

STINNER Victor <[EMAIL PROTECTED]> added the comment: Oops, my previous patch always raise an error even on valid file :-p Here is a new patch with *an unit test* (yeah!). Added file: http://bugs.python.org/file11590/_hotshot_logreader2.patch ___ Python trac

[issue3954] _hotshot: invalid error control in logreader()

New submission from STINNER Victor <[EMAIL PROTECTED]>: Using Fusil the fuzzer, I found a "minor" bug in _hotshot module: it doesn't check correctly the errors in hotshot_logreader(). On error, an exception is raised (eg. by eof_error()) but the result is a pointer to a new allocated object in