[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8, Python 3.9 ___ Python tracker ___

[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

miss-islington added the comment: New changeset 636a850ed81cf9b8feed523f277b1538bfc5230b by Miss Islington (bot) in branch '3.8': bpo-39152: add missing ttk.Scale.configure return value (GH-17815) https://github.com/python/cpython/commit/636a850ed81cf9b8feed523f277b1538bfc5230b --

[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

miss-islington added the comment: New changeset 6234301bb56a9b388a1c3bf51169a2762ea09172 by Miss Islington (bot) in branch '3.7': bpo-39152: add missing ttk.Scale.configure return value (GH-17815) https://github.com/python/cpython/commit/6234301bb56a9b388a1c3bf51169a2762ea09172 -- n

[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

Change by miss-islington : -- pull_requests: +17267 pull_request: https://github.com/python/cpython/pull/17840 ___ Python tracker ___ __

[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

Change by miss-islington : -- pull_requests: +17266 pull_request: https://github.com/python/cpython/pull/17839 ___ Python tracker ___ __

[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

Terry J. Reedy added the comment: New changeset 5ea7bb25e3b192d6c49a49c9e3b316f8559602aa by Terry Jan Reedy in branch 'master': bpo-39152: add missing ttk.Scale.configure return value (GH-17815) https://github.com/python/cpython/commit/5ea7bb25e3b192d6c49a49c9e3b316f8559602aa -- __

[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

Terry J. Reedy added the comment: Giovanni, I saw that you gave a correct fix even if your example was wrong. Currently, scale.configure returns None instead of the configuration. Your patch fixes this. Once I created a git branch to verify and test the fix, it was trivial to make a PR, s

[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

Giovanni Lombardo added the comment: @serhiy.storchaka I didn't found any old issue not closed aboud tkinter Scale widget. -- ___ Python tracker ___ _

[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

Serhiy Storchaka added the comment: There is a special case in tests for Scale.configure. It should be removed now. And maybe there is an old issue for this? -- ___ Python tracker __

[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

Giovanni Lombardo added the comment: Hello Terry J. Reedy, first and foremost thanks for the time you've dedicated to this issue! I really appreciate you work!! Even if I work with Python since 2007, I'm new here, and not very well versed with this issue management system. This has been my f

[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

Terry J. Reedy added the comment: Giovanni, a Python exception is a intended exit. A crash is when the program either hangs or stops unintentionally without a python exception but with an OS error message. I checked and Scale is the only ttk widget that overrides configure. -- type

[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

Change by Terry J. Reedy : -- keywords: +patch pull_requests: +17242 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17815 ___ Python tracker ___ _

[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

Terry J. Reedy added the comment: Your code is buggy because 'cursor' is not a dict or anything like one. On the other hand, adding retval to capture and return the return from Widget.configure looks correct. (And it will not prevent kw.update('cursor') from raising. The current code is

[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

Giovanni Lombardo added the comment: I've modified the `Scale.configure` implementation as follows: ``` def configure(self, cnf=None, **kw): """Modify or query scale options. Setting a value for any of the "from", "from_" or "to" options generates a <> event."""

[issue39152] Faulty override of tkinter.Misc.configure in tkinter.ttk.Scale.configure

New submission from Giovanni Lombardo : The issue arises by simply calling configure on the Scale widget of the themed tk (ttk) widgets set: ``` cursor = scale.configure('cursor')[-1] ``` The above casues the following error: ``` File "C:\Users\Giovanni\Tests\test_scale.py", line 604, in mai