[issue38962] Reference leaks in subinterpreters

Eric Snow added the comment: Thanks for all the work on this! -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list maili

[issue38962] Reference leaks in subinterpreters

STINNER Victor added the comment: The 5 tests don't leak anymore, I close thee issue. Thanks Pablo! $ ./python -m test -R 3:3 -j0 test__xxsubinterpreters test_atexit test_capi test_httpservers test_threading (...) Total duration: 1 min 2 sec Tests result: SUCCESS -- resolution: -> f

[issue38962] Reference leaks in subinterpreters

miss-islington added the comment: New changeset ac0e1c2694bc199dbd073312145e3c09bee52cc4 by Miss Islington (bot) (Pablo Galindo) in branch 'master': bpo-38962: Fix reference leak in the per-subinterpreter gc (GH-17457) https://github.com/python/cpython/commit/ac0e1c2694bc199dbd073312145e3c09b

[issue38962] Reference leaks in subinterpreters

miss-islington added the comment: New changeset b96c6b0723b889d3a0c1740bce7f579f33d246f2 by Miss Islington (bot) (Pablo Galindo) in branch 'master': bpo-38962: Fix reference leak in new_interpreter() (GH-17453) https://github.com/python/cpython/commit/b96c6b0723b889d3a0c1740bce7f579f33d246f2

[issue38962] Reference leaks in subinterpreters

STINNER Victor added the comment: """ 5 tests failed again: test__xxsubinterpreters test_atexit test_capi test_httpservers test_threading """ I merged Pablo's fix for test_httpservers. With PR 17457 + PR 17453 (and the test_httpservers fix), the 5 tests don't leak anymore. I am fine

[issue38962] Reference leaks in subinterpreters

STINNER Victor added the comment: New changeset 24f5cac7254177a4c9956d680c0a9b6dadd85c6f by Victor Stinner (Pablo Galindo) in branch 'master': bpo-38962: Fix reference leak in test_httpservers (GH-17454) https://github.com/python/cpython/commit/24f5cac7254177a4c9956d680c0a9b6dadd85c6f -

[issue38962] Reference leaks in subinterpreters

Change by Pablo Galindo Salgado : -- pull_requests: +16938 pull_request: https://github.com/python/cpython/pull/17457 ___ Python tracker ___ ___

[issue38962] Reference leaks in subinterpreters

Pablo Galindo Salgado added the comment: Opened PR 17457 for the refleaks of test__xxsubinterpreters although I am not very convinced that we can call the GC at that point. -- ___ Python tracker ___

[issue38962] Reference leaks in subinterpreters

Pablo Galindo Salgado added the comment: This patch (which is wrong) fixes the reference issues: diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c index cce4783bc1..c354af18db 100644 --- a/Python/pylifecycle.c +++ b/Python/pylifecycle.c @@ -1276,6 +1276,7 @@ finalize_interp_clear(PyThre

[issue38962] Reference leaks in subinterpreters

Change by Pablo Galindo Salgado : -- pull_requests: +16937 pull_request: https://github.com/python/cpython/pull/17456 ___ Python tracker ___ ___

[issue38962] Reference leaks in subinterpreters

Pablo Galindo Salgado added the comment: I created https://github.com/python/cpython/pull/17455 to revert commit 7247407c35330f3f6292f1d40606b7ba6afd5700 as it seems that the leak is more complex than the others. If a solution is not found in a couple of days we need to merge it to fix the

[issue38962] Reference leaks in subinterpreters

Pablo Galindo Salgado added the comment: Indeed, reverting commit 7247407c35330f3f6292f1d40606b7ba6afd5700 fixes the issues in test_threading -- ___ Python tracker ___ __

[issue38962] Reference leaks in subinterpreters

Pablo Galindo Salgado added the comment: For the subinterpreter other leaks it seems that the commit that introduced the leak is: 7247407c35330f3f6292f1d40606b7ba6afd5700 is the first bad commit commit 7247407c35330f3f6292f1d40606b7ba6afd5700 Author: Victor Stinner Date: Wed Nov 20 12:25:5

[issue38962] Reference leaks in subinterpreters

Change by Pablo Galindo Salgado : -- pull_requests: +16935 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/17454 ___ Python tracker ___

[issue38962] Reference leaks in subinterpreters

Pablo Galindo Salgado added the comment: Opened https://github.com/python/cpython/pull/17454 for the fixing the leak in http_servers -- ___ Python tracker ___ ___

[issue38962] Reference leaks in subinterpreters

Pablo Galindo Salgado added the comment: Indeed, that fixes the problem in at least 2 modules: ./python -m test test_atexit -R : 0:00:00 load avg: 0.84 Run tests sequentially 0:00:00 load avg: 0.84 [1/1] test_atexit beginning 9 repetitions 123456789 . == Tests result: SUCCESS == 1 t

[issue38962] Reference leaks in subinterpreters

Pablo Galindo Salgado added the comment: Ok, the problem seems to be that _PyBuiltin_Init() returns a new reference that is not cleared once PyModule_GetDict() and _PyBuiltins_AddExceptions() is called. -- stage: patch review -> needs patch ___ Py

[issue38962] Reference leaks in subinterpreters

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +16934 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/17453 ___ Python tracker ___

[issue38962] Reference leaks in subinterpreters

Pablo Galindo Salgado added the comment: Actually, that commit has an independent refleak that was fixed (!) regarding the small integer cache. Seems that the actual commit that made the new leak is: commit 2582d46fbcf7bdf86b9cf4016850b8d155267ac6 Author: Victor Stinner Date: Fri Nov 22 19

[issue38962] Reference leaks in subinterpreters

New submission from Pablo Galindo Salgado : All the refleak build bots for master are reporting reference leaks in subinterpreter related tests: https://buildbot.python.org/all/#/builders/126/builds/6/steps/5/logs/stdio https://buildbot.python.org/all/#/builders/144/builds/6/steps/5/logs/stdio