[issue38563] ProactorEventLoop.close(): set_wakeup_fd() only works in main thread

Change by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38563] ProactorEventLoop.close(): set_wakeup_fd() only works in main thread

Carlton Gibson added the comment: Super turn-around. Thank you all. -- resolution: fixed -> status: closed -> open ___ Python tracker ___

[issue38563] ProactorEventLoop.close(): set_wakeup_fd() only works in main thread

STINNER Victor added the comment: Yury and Andrew approved my PR 16901, so I merged it. Thanks for the bug report Carlton Gibson. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue38563] ProactorEventLoop.close(): set_wakeup_fd() only works in main thread

miss-islington added the comment: New changeset cbf474c98e702d12c97cd16a1e44ede10ea52b5b by Miss Skeleton (bot) in branch '3.8': bpo-34679: ProactorEventLoop only uses set_wakeup_fd() in main thread (GH-16901) https://github.com/python/cpython/commit/cbf474c98e702d12c97cd16a1e44ede10ea52b5b

[issue38563] ProactorEventLoop.close(): set_wakeup_fd() only works in main thread

STINNER Victor added the comment: New changeset 1b53a24fb4417c764dd5933bce505f5c94249ca6 by Victor Stinner in branch 'master': bpo-34679: ProactorEventLoop only uses set_wakeup_fd() in main thread (GH-16901) https://github.com/python/cpython/commit/1b53a24fb4417c764dd5933bce505f5c94249ca6 -

[issue38563] ProactorEventLoop.close(): set_wakeup_fd() only works in main thread

Change by miss-islington : -- pull_requests: +16440 pull_request: https://github.com/python/cpython/pull/16902 ___ Python tracker ___ __

[issue38563] ProactorEventLoop.close(): set_wakeup_fd() only works in main thread

Carlton Gibson added the comment: OK, that seems fair :) Will do that tomorrow AM. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue38563] ProactorEventLoop.close(): set_wakeup_fd() only works in main thread

Carlton Gibson added the comment: Thanks for the speedy patch Victor. Great effort! -- ___ Python tracker ___ ___ Python-bugs-list

[issue38563] ProactorEventLoop.close(): set_wakeup_fd() only works in main thread

STINNER Victor added the comment: > Thanks for the speedy patch Victor. Great effort! Can you try to manually test PR 16901? -- ___ Python tracker ___ ___

[issue38563] ProactorEventLoop.close(): set_wakeup_fd() only works in main thread

STINNER Victor added the comment: That's basically the same issue than bpo-34679 but on close() rather than on creating the event loop. -- nosy: +vstinner ___ Python tracker

[issue38563] ProactorEventLoop.close(): set_wakeup_fd() only works in main thread

Change by STINNER Victor : -- keywords: +patch pull_requests: +16438 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16901 ___ Python tracker ___ _

[issue38563] ProactorEventLoop.close(): set_wakeup_fd() only works in main thread

Change by STINNER Victor : -- title: Asyncio regression on Windows with Python 3.8 -> ProactorEventLoop.close(): set_wakeup_fd() only works in main thread ___ Python tracker _