[issue38453] ntpath.realpath() does not fully resolve relative paths

Steve Dower added the comment: Closing this as I believe it's done, but happy to reopen if we find another edge case (or start a new issue). -- assignee: -> steve.dower resolution: -> fixed stage: patch review -> resolved status: open -> closed _

[issue38453] ntpath.realpath() does not fully resolve relative paths

miss-islington added the comment: New changeset 6f602fbd3568ed7bebadfa3c7d3de40a271216f9 by Miss Islington (bot) in branch '3.8': bpo-38453: Ensure correct short path is obtained for test (GH-17184) https://github.com/python/cpython/commit/6f602fbd3568ed7bebadfa3c7d3de40a271216f9 --

[issue38453] ntpath.realpath() does not fully resolve relative paths

Steve Dower added the comment: New changeset 7c6130c8c36c941255365e5414c956fc919b8629 by Steve Dower in branch 'master': bpo-38453: Ensure correct short path is obtained for test (GH-17184) https://github.com/python/cpython/commit/7c6130c8c36c941255365e5414c956fc919b8629 -- ___

[issue38453] ntpath.realpath() does not fully resolve relative paths

Change by miss-islington : -- pull_requests: +16693 pull_request: https://github.com/python/cpython/pull/17186 ___ Python tracker ___ __

[issue38453] ntpath.realpath() does not fully resolve relative paths

Change by Steve Dower : -- pull_requests: +16691 pull_request: https://github.com/python/cpython/pull/17184 ___ Python tracker ___ _

[issue38453] ntpath.realpath() does not fully resolve relative paths

Steve Dower added the comment: Thanks, Victor! That looks different from the one I was originally fixing (even though the long/short path mismatch is there), so I'll take a look. -- ___ Python tracker _

[issue38453] ntpath.realpath() does not fully resolve relative paths

Steve Dower added the comment: New changeset 66c0f01f98fd6db0a4b1e789b9db9c7247a24ba9 by Steve Dower in branch '3.8': bpo-38453: Ensure ntpath.realpath correctly resolves relative paths (GH-16967) https://github.com/python/cpython/commit/66c0f01f98fd6db0a4b1e789b9db9c7247a24ba9 --

[issue38453] ntpath.realpath() does not fully resolve relative paths

STINNER Victor added the comment: Grumpy AMD64 Windows10 3.x: https://buildbot.python.org/all/#/builders/3/builds/3788 == FAIL: test_realpath_cwd (test.test_ntpath.TestNtpath) --

[issue38453] ntpath.realpath() does not fully resolve relative paths

STINNER Victor added the comment: AMD64 Windows8.1 Non-Debug 3.x is grumpy: https://buildbot.python.org/all/#/builders/12/builds/3459 == FAIL: test_realpath_cwd (test.test_ntpath.TestNtpath) ---

[issue38453] ntpath.realpath() does not fully resolve relative paths

Change by Steve Dower : -- pull_requests: +16682 pull_request: https://github.com/python/cpython/pull/17174 ___ Python tracker ___ _

[issue38453] ntpath.realpath() does not fully resolve relative paths

Steve Dower added the comment: New changeset abde52cd8e31830bfc06c5803221faae6172104a by Steve Dower in branch 'master': bpo-38453: Ensure ntpath.realpath correctly resolves relative paths (GH-16967) https://github.com/python/cpython/commit/abde52cd8e31830bfc06c5803221faae6172104a -

[issue38453] ntpath.realpath() does not fully resolve relative paths

Steve Dower added the comment: I think the PR as it stands is a net improvement over where we currently are, so I'll merge it. We can make more tweaks as necessary. -- ___ Python tracker ___

[issue38453] ntpath.realpath() does not fully resolve relative paths

Steve Dower added the comment: My latest push to PR 16967 is a significant change to what ntpath.realpath will return for broken symlinks, but I think it's the right change. Basically, if the OS fully resolves the path, great! We'll return that (and handle \\?\ stripping) If the OS doesn't,

[issue38453] ntpath.realpath() does not fully resolve relative paths

Steve Dower added the comment: The discussion on the PR has raised one scenario where our algorithm conflicts with what we can reasonably emulate from the IO manager (which is itself not entirely self-consistent): If you call ntpath.realpath(r"C:\spam\eggs") where "spam" is a symlink/junctio

[issue38453] ntpath.realpath() does not fully resolve relative paths

Steve Dower added the comment: I also had to special-case "realpath('nul')" to maintain the behaviour that we deliberately maintained in another bug, and I think isabs() should always return true for "\\?\" prefixed paths (given that join() will promote a "\\?\" prefixed path to the root).

[issue38453] ntpath.realpath() does not fully resolve relative paths

Steve Dower added the comment: PR 16967 should fix the relative path resolution property, by joining with cwd if the original path is unprefixed and not absolute, and then joining with any symlink directories if their link is not absolute. -- ___

[issue38453] ntpath.realpath() does not fully resolve relative paths

Change by Steve Dower : -- pull_requests: +16494 pull_request: https://github.com/python/cpython/pull/16967 ___ Python tracker ___ _

[issue38453] ntpath.realpath() does not fully resolve relative paths

Change by Steve Dower : -- title: ntpath.realpath() should make absolute path earlier -> ntpath.realpath() does not fully resolve relative paths ___ Python tracker ___ ___