[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

Daniel Hillier added the comment: Thanks for your help! Good point, I'll create a new change for the refactoring. -- ___ Python tracker ___ ___

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

Serhiy Storchaka added the comment: > I got carried away refactoring the decrypter for a future scenario where > there could be different decrypters (possibly using certificates too) :) The decrypter was implemented with a generator for performance. The performance of decrypting is not criti

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

miss-islington added the comment: New changeset ed2db3113d54a5f8af1b419a9f5fdf3642285c82 by Miss Skeleton (bot) in branch '3.7': bpo-38334: Fix seeking backward on an encrypted zipfile.ZipExtFile. (GH-16937) https://github.com/python/cpython/commit/ed2db3113d54a5f8af1b419a9f5fdf3642285c82 -

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

miss-islington added the comment: New changeset 76fbdaa2a693caaa1b8eb34104720fc774ff80df by Miss Skeleton (bot) in branch '3.8': bpo-38334: Fix seeking backward on an encrypted zipfile.ZipExtFile. (GH-16937) https://github.com/python/cpython/commit/76fbdaa2a693caaa1b8eb34104720fc774ff80df -

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

Change by miss-islington : -- pull_requests: +16479 pull_request: https://github.com/python/cpython/pull/16951 ___ Python tracker ___ __

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

Change by miss-islington : -- pull_requests: +16480 pull_request: https://github.com/python/cpython/pull/16952 ___ Python tracker ___ __

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

Serhiy Storchaka added the comment: New changeset 5c32af7522d908e8c7da0243af37618433289cc5 by Serhiy Storchaka in branch 'master': bpo-38334: Fix seeking backward on an encrypted zipfile.ZipExtFile. (GH-16937) https://github.com/python/cpython/commit/5c32af7522d908e8c7da0243af37618433289cc5

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

Daniel Hillier added the comment: I also think that the `read_init` method in my PR is a useful refactor as it locates all the state that needs to be (re)set when starting a read into the same location. At the moment this state is set in 1) __init__ and 2) the seek method when seeking back

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

Daniel Hillier added the comment: Thanks for looking at the PR. I got carried away refactoring the decrypter for a future scenario where there could be different decrypters (possibly using certificates too) :) Your PR is much simpler. Would you also be able to take a look at some other PRs

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

Serhiy Storchaka added the comment: PR 16937 is simpler. It does not change the decrypter. -- ___ Python tracker ___ ___ Python-bug

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

Change by Serhiy Storchaka : -- pull_requests: +16466 pull_request: https://github.com/python/cpython/pull/16937 ___ Python tracker ___

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

Daniel Hillier added the comment: Hi, I have another patch I would like to contribute to the zipfile module but would like to request a review of this one to minimise conflicts with later patches. If anyone is able to review the patch, I would really appreciate it :) Also, with regards to s

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

Change by Daniel Hillier : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

Change by Daniel Hillier : -- keywords: +patch pull_requests: +16120 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16529 ___ Python tracker ___ _

[issue38334] zipfile: Seeking encrypted file breaks after seeking backwards

New submission from Daniel Hillier : Seeking back beyond the decrypted / unzipped buffer doesn't reset the decrypter's crc key values. All data read after seeking back beyond the buffer is garbled. -- components: Library (Lib) messages: 353646 nosy: dhillier priority: normal severity: