[issue38252] Use 8-byte step to detect ASCII sequence in 64bit Windows builds

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38252] Use 8-byte step to detect ASCII sequence in 64bit Windows builds

Serhiy Storchaka added the comment: New changeset a0c603cb9d4dbb9909979313a88bcd1f5fde4f62 by Ma Lin in branch 'master': bpo-38252: Use 8-byte step to detect ASCII sequence in 64bit Windows build (GH-16334) https://github.com/python/cpython/commit/a0c603cb9d4dbb9909979313a88bcd1f5fde4f62 -

[issue38252] Use 8-byte step to detect ASCII sequence in 64bit Windows builds

Ma Lin added the comment: Although the improvement is not great, it's a very hot code path. Could you review the PR? -- components: +Windows nosy: +paul.moore, tim.golden ___ Python tracker

[issue38252] Use 8-byte step to detect ASCII sequence in 64bit Windows builds

Change by Cheryl Sabella : -- nosy: +steve.dower, zach.ware versions: +Python 3.10 -Python 3.9 ___ Python tracker ___ ___ Python-bug

[issue38252] Use 8-byte step to detect ASCII sequence in 64bit Windows builds

Ma Lin added the comment: There are 4 functions have the similar code, see PR 16334. Just replaced the `unsigned long` type with `size_t` type, got these benchmarks. Can this be backported to 3.8 branch? 1. bytes.isascii() D:\dev\cpython\PCbuild\amd64\python.exe -m pyperf timeit -s "b = b'x'

[issue38252] Use 8-byte step to detect ASCII sequence in 64bit Windows builds

Change by Ma Lin : -- title: micro-optimize ucs1lib_find_max_char in Windows 64-bit build -> Use 8-byte step to detect ASCII sequence in 64bit Windows builds ___ Python tracker __