[issue37648] Fix minor inconsistency in the order of == operands

2019-09-13 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Just to add list.__contains__ and others might cause subtle changes as noted. One example is around discussion at https://github.com/python/cpython/pull/14700#discussion_r324054193 where my code to fix mock.ANY was depending on this behavior to wor

[issue37648] Fix minor inconsistency in the order of == operands

2019-08-04 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37648] Fix minor inconsistency in the order of == operands

2019-08-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 18b711c5a7f90d88fb74748f18fa8ef49d8486c7 by Serhiy Storchaka in branch 'master': bpo-37648: Fixed minor inconsistency in some __contains__. (GH-14904) https://github.com/python/cpython/commit/18b711c5a7f90d88fb74748f18fa8ef49d8486c7

[issue37648] Fix minor inconsistency in the order of == operands

2019-07-22 Thread Josh Rosenberg
Change by Josh Rosenberg : -- nosy: +josh.r ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue37648] Fix minor inconsistency in the order of == operands

2019-07-22 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue37648] Fix minor inconsistency in the order of == operands

2019-07-22 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- nosy: +gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue37648] Fix minor inconsistency in the order of == operands

2019-07-22 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +14682 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14904 ___ Python tracker ___

[issue37648] Fix minor inconsistency in the order of == operands

2019-07-22 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : There is two ways to write the comparison when we search an item equal to the needle: item == needle and needle == item In most cases they get the same result. But if __eq__ of the item or the needle is not correctly implemented (returns False