[issue37347] Reference-counting problem in sqlite

Change by Sergey Fedoseev : -- pull_requests: +16894 pull_request: https://github.com/python/cpython/pull/17413 ___ Python tracker ___ _

[issue37347] Reference-counting problem in sqlite

miss-islington added the comment: New changeset 36101c2c5daf692d1716e17720c6c5197f28e25d by Miss Islington (bot) in branch '3.8': closes bpo-37347: Fix refcount problem in sqlite3. (GH-14268) https://github.com/python/cpython/commit/36101c2c5daf692d1716e17720c6c5197f28e25d -- nosy:

[issue37347] Reference-counting problem in sqlite

Change by miss-islington : -- pull_requests: +14521 pull_request: https://github.com/python/cpython/pull/14725 ___ Python tracker ___ __

[issue37347] Reference-counting problem in sqlite

Benjamin Peterson added the comment: New changeset b9a0376b0dedf16a2f82fa43d851119d1f7a2707 by Benjamin Peterson (gescheit) in branch 'master': closes bpo-37347: Fix refcount problem in sqlite3. (GH-14268) https://github.com/python/cpython/commit/b9a0376b0dedf16a2f82fa43d851119d1f7a2707 ---

[issue37347] Reference-counting problem in sqlite

Aleksandr Balezin added the comment: I've pushed changes https://github.com/python/cpython/pull/14268/commits/bce7fdc952b14c23821e184e82b3944f6e10aaa9. Could I ask for clarification on callback and Py_DECREF(something)? -- ___ Python tracker

[issue37347] Reference-counting problem in sqlite

Benjamin Peterson added the comment: The _sqlite3 module clearly is not free of bugs in this area. Binding the Python function to the exact lifetime of the sqlite function seems less likely to be buggy than replicating sqlite's function reference management independently. sqlite3_create_func

[issue37347] Reference-counting problem in sqlite

Aleksandr Balezin added the comment: At my point of view, dererencing from sqlite destructor has next flaws: - relying on external library which can has bugs - using different routine for reference-counting(complicates code) - loosing support for old sqlite version Of cause, if it's necessary

[issue37347] Reference-counting problem in sqlite

Benjamin Peterson added the comment: But there can be only one progress handler per connection, so you can just keep an single reference in the struct yourself. -- ___ Python tracker ___

[issue37347] Reference-counting problem in sqlite

Aleksandr Balezin added the comment: Because destructor can be registered only for particular functions. For example sqlite3_progress_handler() can't register destructor. -- ___ Python tracker _

[issue37347] Reference-counting problem in sqlite

Benjamin Peterson added the comment: Why not use sqlite3_create_function_v2 to register a destructor for the function that does Py_DECREF and dispense with the dictionaries entirely? -- nosy: +benjamin.peterson ___ Python tracker

[issue37347] Reference-counting problem in sqlite

Change by Karthikeyan Singaravelan : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37347] Reference-counting problem in sqlite

Change by Aleksandr Balezin : -- pull_requests: -14092 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue37347] Reference-counting problem in sqlite

Change by Aleksandr Balezin : -- pull_requests: +14094 pull_request: https://github.com/python/cpython/pull/14268 ___ Python tracker ___ ___

[issue37347] Reference-counting problem in sqlite

Change by Aleksandr Balezin : -- keywords: +patch pull_requests: +14092 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14265 ___ Python tracker __

[issue37347] Reference-counting problem in sqlite

Change by Aleksandr Balezin : Added file: https://bugs.python.org/file48430/bug.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue37347] Reference-counting problem in sqlite

New submission from Aleksandr Balezin : There are a couple of bugs in sqlite bindings have been found related to reference-counting. Short info: sqlite connection class uses a dict to keep references to callbacks. This mechanism is not suitable for objects which equals but not the same. con =