[issue37333] Fail build on windows 10(visual studio 2019)

2019-06-19 Thread miss-islington
miss-islington added the comment: New changeset 389abd37ba50a327ae7388c6b016604cbd980e4b by Miss Islington (bot) in branch '3.8': bpo-37333: Ensure IncludeTkinter has a value (GH-14240) https://github.com/python/cpython/commit/389abd37ba50a327ae7388c6b016604cbd980e4b -- nosy: +miss-

[issue37333] Fail build on windows 10(visual studio 2019)

2019-06-19 Thread Steve Dower
Steve Dower added the comment: Backport will automerge when it's done. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue37333] Fail build on windows 10(visual studio 2019)

2019-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +14078 pull_request: https://github.com/python/cpython/pull/14243 ___ Python tracker ___ __

[issue37333] Fail build on windows 10(visual studio 2019)

2019-06-19 Thread Steve Dower
Steve Dower added the comment: New changeset 12f1c726d8328e5e096c35c36901f6d19bc942d3 by Steve Dower in branch 'master': bpo-37333: Ensure IncludeTkinter has a value (GH-14240) https://github.com/python/cpython/commit/12f1c726d8328e5e096c35c36901f6d19bc942d3 --

[issue37333] Fail build on windows 10(visual studio 2019)

2019-06-19 Thread Steve Dower
Change by Steve Dower : -- assignee: -> steve.dower type: -> compile error versions: +Python 3.8 ___ Python tracker ___ ___ Python

[issue37333] Fail build on windows 10(visual studio 2019)

2019-06-19 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +14075 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14240 ___ Python tracker ___

[issue37333] Fail build on windows 10(visual studio 2019)

2019-06-19 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Probably related issue where the flag was added to python.vcxproj : issue37288 -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, xtreak, zach.ware ___ Python tracker

[issue37333] Fail build on windows 10(visual studio 2019)

2019-06-18 Thread Андрей Казанцев
New submission from Андрей Казанцев : Error MSB4113 Specified condition "$(IncludeTkinter)" evaluates to "" instead of a boolean. python cpython\PCbuild\python.vcxproj 156 It is the master branch (id: 0a28f8d379544eee897979da0ce99f0b449b49dd) -- components: Build messages: 346019