[issue37221] PyCode_New API change breaks backwards compatibility policy

miss-islington added the comment: New changeset ed4614386f210964840daa1f7cbddbbd575f7a49 by Miss Islington (bot) in branch '3.9': bpo-37221: PyCode_New() didn't change in Python 3.8 (GH-23595) https://github.com/python/cpython/commit/ed4614386f210964840daa1f7cbddbbd575f7a49 --

[issue37221] PyCode_New API change breaks backwards compatibility policy

miss-islington added the comment: New changeset d9d63f13cf5b6b896c245099c42b08f6da083d05 by Miss Islington (bot) in branch '3.8': bpo-37221: PyCode_New() didn't change in Python 3.8 (GH-23595) https://github.com/python/cpython/commit/d9d63f13cf5b6b896c245099c42b08f6da083d05 --

[issue37221] PyCode_New API change breaks backwards compatibility policy

Change by miss-islington : -- pull_requests: +22469 pull_request: https://github.com/python/cpython/pull/23600 ___ Python tracker ___ __

[issue37221] PyCode_New API change breaks backwards compatibility policy

Change by miss-islington : -- nosy: +miss-islington nosy_count: 9.0 -> 10.0 pull_requests: +22468 pull_request: https://github.com/python/cpython/pull/23599 ___ Python tracker

[issue37221] PyCode_New API change breaks backwards compatibility policy

STINNER Victor added the comment: New changeset 1867b462de427bcb8dfbcd256028410aea6ae929 by Victor Stinner in branch 'master': bpo-37221: PyCode_New() didn't change in Python 3.8 (GH-23595) https://github.com/python/cpython/commit/1867b462de427bcb8dfbcd256028410aea6ae929 -- ___

[issue37221] PyCode_New API change breaks backwards compatibility policy

Change by STINNER Victor : -- pull_requests: +22463 pull_request: https://github.com/python/cpython/pull/23595 ___ Python tracker ___ __

[issue37221] PyCode_New API change breaks backwards compatibility policy

Stefan Behnel added the comment: No need to keep this bug open on CPython side. The backwards compatibility has been restored (and I'll release Cython 0.29.12 today to resolve the issue on that side.) -- resolution: -> fixed status: open -> closed __

[issue37221] PyCode_New API change breaks backwards compatibility policy

STINNER Victor added the comment: I created https://github.com/cython/cython/issues/3034 "Cython doesn't work on Python 3.8 beta2" -- ___ Python tracker ___ _

[issue37221] PyCode_New API change breaks backwards compatibility policy

STINNER Victor added the comment: I reopen the issue. Cython 0.29.11 doesn't work on Python 3.8 beta2. Installation fails with a compiler error: Cython-0.29.11/Cython/Plex/Scanners.c:7244:274: error: macro "__Pyx_PyCode_New" requires 16 arguments, but only 15 given Cython commit 0d888391680

[issue37221] PyCode_New API change breaks backwards compatibility policy

Change by Petr Viktorin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue37221] PyCode_New API change breaks backwards compatibility policy

Stefan Behnel added the comment: > Is it part of Cython 0.29.11 released yesterday? Yes. -- ___ Python tracker ___ ___ Python-bugs

[issue37221] PyCode_New API change breaks backwards compatibility policy

Łukasz Langa added the comment: New changeset cb083f7cdf604c1d9d264f387f9e8846bc953eb3 by Łukasz Langa (Miss Islington (bot)) in branch '3.8': bpo-37221: Add PyCode_NewWithPosOnlyArgs to be used internally and set PyCode_New as a compatibility wrapper (GH-13959) (#14505) https://github.com/py

[issue37221] PyCode_New API change breaks backwards compatibility policy

Petr Viktorin added the comment: > https://github.com/cython/cython/pull/3009 was merged. (to master, so far) > Is it part of Cython 0.29.11 released yesterday? It should be, see: https://cython.readthedocs.io/en/latest/src/changes.html#id2 -- __

[issue37221] PyCode_New API change breaks backwards compatibility policy

STINNER Victor added the comment: https://github.com/cython/cython/pull/3009 was merged. Is it part of Cython 0.29.11 released yesterday? -- ___ Python tracker ___ __

[issue37221] PyCode_New API change breaks backwards compatibility policy

Change by miss-islington : -- pull_requests: +14321 pull_request: https://github.com/python/cpython/pull/14505 ___ Python tracker ___ __

[issue37221] PyCode_New API change breaks backwards compatibility policy

Petr Viktorin added the comment: New changeset 4a2edc34a405150d0b23ecfdcb401e7cf59f4650 by Petr Viktorin (Pablo Galindo) in branch 'master': bpo-37221: Add PyCode_NewWithPosOnlyArgs to be used internally and set PyCode_New as a compatibility wrapper (GH-13959) https://github.com/python/cpyth

[issue37221] PyCode_New API change breaks backwards compatibility policy

Stefan Behnel added the comment: I'm really only waiting for bpo-37250 to be resolved, then I can prepare a new point release of Cython, preferably this week. -- ___ Python tracker _

[issue37221] PyCode_New API change breaks backwards compatibility policy

STINNER Victor added the comment: > That means we're back to either breaking Cython compatibility with CPython > master until the release is cut Yeah, that was my plan: merge PR 13959 "just before" beta2, and try to get a Cython release ASAP. The best case would be to get a Cython release w

[issue37221] PyCode_New API change breaks backwards compatibility policy

Nick Coghlan added the comment: In reviewing https://github.com/cython/cython/pull/3009, Jeroen pointed out that my symbol checking idea wouldn't actually work, since the preprocessor can only see preprocessor definitions, not compiler symbols. If we're going to rely on a preprocessor defini

[issue37221] PyCode_New API change breaks backwards compatibility policy

Nick Coghlan added the comment: I'm happy with the change in https://github.com/python/cpython/pull/13959, but we need sign-off from Łukasz as release manager on bumping the Py_VERSION_SERIAL a bit early so Cython can reliably detect that this change has been reverted without having to check

[issue37221] PyCode_New API change breaks backwards compatibility policy

Change by Jeroen Demeyer : -- pull_requests: -13873 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue37221] PyCode_New API change breaks backwards compatibility policy

STINNER Victor added the comment: Jeroen Demeyer: > I think that the PyCode_New() compatibility problem and tp_print are > sufficiently closely related that they can be discussed together. IMHO these problems are different enough to justify to have a separated issue: I created https://bugs.p

[issue37221] PyCode_New API change breaks backwards compatibility policy

Jeroen Demeyer added the comment: I think that the PyCode_New() compatibility problem and tp_print are sufficiently closely related that they can be discussed together. In any case, I agree that it makes little sense to fix just one. -- ___ Python

[issue37221] PyCode_New API change breaks backwards compatibility policy

STINNER Victor added the comment: > Note that PyCode_New() is not the only change in 3.8 beta1 that breaks Cython > generated code. The renaming of "tp_print" to "tp_vectorcall" is equally > disruptive, because Cython has (or had) a work-around for CPython > (mis-)behaviour that reset the fi

[issue37221] PyCode_New API change breaks backwards compatibility policy

Jeroen Demeyer added the comment: PR 14009 deals with tp_print -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue37221] PyCode_New API change breaks backwards compatibility policy

Change by Jeroen Demeyer : -- keywords: +patch pull_requests: +13873 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14009 ___ Python tracker __

[issue37221] PyCode_New API change breaks backwards compatibility policy

Jeroen Demeyer added the comment: Technically, tp_print was replaced by tp_vectorcall_offset. But that doesn't answer the question how we should deal with tp_print backwards compatibility. Cython does FooType.tp_print = 0; With this in mind, simply replacing tp_print by tp_vectorcall_offset

[issue37221] PyCode_New API change breaks backwards compatibility policy

Pablo Galindo Salgado added the comment: Adding Petr, that was involved with the "tp_print" to "tp_vectorcall" renaming. -- nosy: +petr.viktorin ___ Python tracker ___ ___

[issue37221] PyCode_New API change breaks backwards compatibility policy

Stefan Behnel added the comment: Note that PyCode_New() is not the only change in 3.8 beta1 that breaks Cython generated code. The renaming of "tp_print" to "tp_vectorcall" is equally disruptive, because Cython has (or had) a work-around for CPython (mis-)behaviour that reset the field expli

[issue37221] PyCode_New API change breaks backwards compatibility policy

STINNER Victor added the comment: > If we do have to make a similar incompatible change in the future, (...) IMHO the most important learnt lesson here is that we lack a proper Continuous Integration of the master branch of Python and popular PyPI projects. We should be notified *before* a r

[issue37221] PyCode_New API change breaks backwards compatibility policy

Neil Schemenauer added the comment: I suggest we change PyCode_New() back in the next beta, despite that change breaking Cython again. We could work with them so that they have a new release with a "PY_VERSION_HEX > 0x030800b1" test in it. Try to get that Cython version released before 3.8b

[issue37221] PyCode_New API change breaks backwards compatibility policy

Pablo Galindo Salgado added the comment: I updated the PR and Victor reviewed it. Nick, could you review it as well? -- ___ Python tracker ___

[issue37221] PyCode_New API change breaks backwards compatibility policy

Nick Coghlan added the comment: The key problem isn't Cython itself, the problem is that Cython generated libraries can't be rebuilt for 3.8 without regenerating their C files. I'd be fine with PyCode_NewWithPosArgs (Victor's right that a descriptive naming convention handles future changes

[issue37221] PyCode_New API change breaks backwards compatibility policy

STINNER Victor added the comment: It seems like very few pepople are testing Python 3.8 so far. I'm making this assumption because many projects using Cython cannot be installed on Python 3.8 and I didn't see much complain so far. My Python Maintenance team at Red Hat is working on fixing al

[issue37221] PyCode_New API change breaks backwards compatibility policy

STINNER Victor added the comment: I would prefer to revert PyCode_New() API (to Python 3.7 and older API), and add a *new* function for positional-only arguments. > I have created PR13959 in case we decide to go with the PyCode_NewEx path. I dislike "Ex" suffix. What will be next name? Ex2?

[issue37221] PyCode_New API change breaks backwards compatibility policy

Pablo Galindo Salgado added the comment: > You already broke backwards compatibility once in beta1 There is one other thing to consider, that is projects with pinned dependencies will have to upgrade to the last Cython and update their generated sources if we don't do the renaming. I don't k

[issue37221] PyCode_New API change breaks backwards compatibility policy

Jeroen Demeyer added the comment: > Take into account that doing such rename will break again the projects that > have adapted already (primarily only Cython). +1. You already broke backwards compatibility once in beta1, no need to do it again in beta2. -- nosy: +jdemeyer _

[issue37221] PyCode_New API change breaks backwards compatibility policy

Serhiy Storchaka added the comment: Seems it was changed last time many years ago and was stable in Python 3. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue37221] PyCode_New API change breaks backwards compatibility policy

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue37221] PyCode_New API change breaks backwards compatibility policy

Change by Pablo Galindo Salgado : -- nosy: +scoder ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue37221] PyCode_New API change breaks backwards compatibility policy

Pablo Galindo Salgado added the comment: I have created PR13959 in case we decide to go with the PyCode_NewEx path. -- keywords: -patch stage: patch review -> needs patch ___ Python tracker

[issue37221] PyCode_New API change breaks backwards compatibility policy

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +13825 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/13959 ___ Python tracker ___

[issue37221] PyCode_New API change breaks backwards compatibility policy

Pablo Galindo Salgado added the comment: Thanks, Nick for opening this issue. If everyone agrees this is the best path forward I can make a PR. Take into account that doing such rename will break again the projects that have adapted already (primarily only Cython). I would like to give some

[issue37221] PyCode_New API change breaks backwards compatibility policy

STINNER Victor added the comment: PyCode_New() and types.CodeType constructor are actively discussed: * https://mail.python.org/archives/list/python-...@python.org/thread/VXDPH2TUAHNPT5K6HBUIV6VASBCKKY2K/ * bpo-36896 * bpo-36886 -- nosy: +vstinner ___

[issue37221] PyCode_New API change breaks backwards compatibility policy

New submission from Nick Coghlan : The Porting section of the What's New guide is for changes where the old behaviour was at best arguably correct, but it's still possible someone was relying on it behaving exactly the way it used to. It isn't for us to say "We broke all extensions that use t