[issue37039] IDLE: Improve zoomheight doc and behavior.

Tal Einat added the comment: Hey, I did the implementation too! :) I'm really happy to see this fixed in time for 3.8. -- ___ Python tracker ___ _

[issue37039] IDLE: Improve zoomheight doc and behavior.

Terry J. Reedy added the comment: Thank you Andre for the reports and followup and Tal for the research. I can start using this now. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue37039] IDLE: Improve zoomheight doc and behavior.

Terry J. Reedy added the comment: New changeset 4b68a8eb0df7317d6c57b021d40cc0b31e3f1cd3 by Terry Jan Reedy (Miss Islington (bot)) in branch '3.8': bpo-37039: Make IDLE's Zoom Height adjust to users' screens (GH-13678) (GH-14168) https://github.com/python/cpython/commit/4b68a8eb0df7317d6c57b

[issue37039] IDLE: Improve zoomheight doc and behavior.

miss-islington added the comment: New changeset 0f31a2d3e85d3644de30626a00439ab3c7424105 by Miss Islington (bot) in branch '3.7': bpo-37039: Make IDLE's Zoom Height adjust to users' screens (GH-13678) https://github.com/python/cpython/commit/0f31a2d3e85d3644de30626a00439ab3c7424105

[issue37039] IDLE: Improve zoomheight doc and behavior.

Change by miss-islington : -- pull_requests: +14010 pull_request: https://github.com/python/cpython/pull/14168 ___ Python tracker ___ __

[issue37039] IDLE: Improve zoomheight doc and behavior.

Change by miss-islington : -- pull_requests: +14009 pull_request: https://github.com/python/cpython/pull/14167 ___ Python tracker ___ __

[issue37039] IDLE: Improve zoomheight doc and behavior.

Terry J. Reedy added the comment: New changeset 5bff3c86ab77e9d831b3cd19b45654c7eef22931 by Terry Jan Reedy (Tal Einat) in branch 'master': bpo-37039: Make IDLE's Zoom Height adjust to users' screens (GH-13678) https://github.com/python/cpython/commit/5bff3c86ab77e9d831b3cd19b45654c7eef22931

[issue37039] IDLE: Improve zoomheight doc and behavior.

Change by Terry J. Reedy : -- versions: +Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue37039] IDLE: Improve zoomheight doc and behavior.

Andre Roberge added the comment: As I wrote on Github: On my computer (Windows 10, resolution: 3000 x 2000, scaling of UI elements set to 200%), clicking on Zoom Height makes Idle go full screen. Clicking on the same menu (now called Restore Height) does absolutely nothing: Idle stays in full

[issue37039] IDLE: Improve zoomheight doc and behavior.

Tal Einat added the comment: See an implementation in PR GH-13678. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue37039] IDLE: Improve zoomheight doc and behavior.

Change by Tal Einat : -- pull_requests: +13566 pull_request: https://github.com/python/cpython/pull/13678 ___ Python tracker ___ ___

[issue37039] IDLE: Improve zoomheight doc and behavior.

Tal Einat added the comment: I haven't found a way to maximize a hidden window; being "zoomed" and "withdrawn" are both considered "states" by Tk, and apparently a window cannot be in both states simultaneously. An alternative is, when zooming the height: 1. save the current window position

[issue37039] IDLE: Improve zoomheight doc and behavior.

miss-islington added the comment: New changeset abdda3ae2a19326bb10bb6e54400c5d3a904b742 by Miss Islington (bot) in branch '3.7': bpo-37039: IDLE - zoomheight fixes (GH-13576) https://github.com/python/cpython/commit/abdda3ae2a19326bb10bb6e54400c5d3a904b742 -- nosy: +miss-islington

[issue37039] IDLE: Improve zoomheight doc and behavior.

Change by miss-islington : -- pull_requests: +13508 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/13602 ___ Python tracker ___ ___

[issue37039] IDLE: Improve zoomheight doc and behavior.

Terry J. Reedy added the comment: Tal, please go ahead after updating your repository. I just merged PR 13576 after reverting the change from 72 to 114 that only works for me and adding Skip News. Include a blurb with your patch. It only needs to include something like "Fix zoom height cal

[issue37039] IDLE: Improve zoomheight doc and behavior.

Terry J. Reedy added the comment: New changeset df9b032f47e4edaf306d95449370e565ee470018 by Terry Jan Reedy in branch 'master': bpo-37039: IDLE - zoomheight fixes (GH-13576) https://github.com/python/cpython/commit/df9b032f47e4edaf306d95449370e565ee470018 -- ___

[issue37039] IDLE: Improve zoomheight doc and behavior.

Andre Roberge added the comment: I volunteer to do some testing. In addition to the problem I noted on my computer where the status bar disappeared behind the task bar, I noticed that on my secondary 4k monitor (resolution: 3840 x 2160), clicking Zoom Height resulted in a window stretched only

[issue37039] IDLE: Improve zoomheight doc and behavior.

Tal Einat added the comment: To get the maximum available height, does Tk's wm_maxsize() not work? https://www.tcl.tk/man/tcl8.6/TkCmd/wm.htm#M54 Answering my own question above: No, it gives the total screen height, which doesn't ignore e.g. taskbars. The best way to get the actual availab

[issue37039] IDLE: Improve zoomheight doc and behavior.

Terry J. Reedy added the comment: When you start, it should say 'Zoom Height', then 'Restore Height' after you maximize. But if on a screen small enough that the initial height is the same as zoomed, IDLE might get confused. No change on Linux in the PR is the intention, so that is good.

[issue37039] IDLE: Improve zoomheight doc and behavior.

Serhiy Storchaka added the comment: I do not have "Zoom/Restore Height". I have only "Restore Height" which maximizes the height. The result looks identical with and without PR 13576 applied. There is no overlapping nor gap between the IDLE windows and the bottom panel. --

[issue37039] IDLE: Improve zoomheight doc and behavior.

Terry J. Reedy added the comment: Andre, we need to severely trim quotes when posting by email. A summary with added info. Andre: 2000 pixels / 183 mm = 10.9 pixels / mm Terry: 1440 pixels / 336 mm = 4.3 pixels / mm Andre: Windows Display setting text size, custom scaling = 200%, 200% Terry:

[issue37039] IDLE: Improve zoomheight doc and behavior.

Andre Roberge added the comment: On Sat, May 25, 2019 at 9:49 PM Terry J. Reedy wrote: > > Terry J. Reedy added the comment: > > Thank you. Along with your path browser report, things are much > clearer. With variable pixel densities and custom settings, we cannot > use fixed pixel or even

[issue37039] IDLE: Improve zoomheight doc and behavior.

Terry J. Reedy added the comment: Thank you. Along with your path browser report, things are much clearer. With variable pixel densities and custom settings, we cannot use fixed pixel or even mm numbers. 114 is right for me because I have Display Setting "Change the size of text, apps, and

[issue37039] IDLE: Improve zoomheight doc and behavior.

Andre Roberge added the comment: Thanks. I did a quick check. 114 solves the problem of the Restore Height not working, but the status bar is still hidden. To me, the crucial part of the problem was the restore height not working, so I'd be happy with this. At 164, I can see parts of the stat

[issue37039] IDLE: Improve zoomheight doc and behavior.

Terry J. Reedy added the comment: The current patch fixed the hidden status bar on Windows. I just had to increase the margin reserved for the taskbar from 76 to 114. This will also work if the taskbar is moved to the top of the screen. If the taskbar is moved to either side or if it is l

[issue37039] IDLE: Improve zoomheight doc and behavior.

Terry J. Reedy added the comment: Tal, how is zoom/restore height working on your Mac? On my updated Macbook Air Mohave, the zoom bottom margin of 88 is too large. Since IDLE starts fully zoomed on this small screen, I determined this by shrinking Shell and then zooming it. The result leav

[issue37039] IDLE: Improve zoomheight doc and behavior.

Change by Terry J. Reedy : -- keywords: +patch pull_requests: +13483 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/13576 ___ Python tracker __

[issue37039] IDLE: Improve zoomheight doc and behavior.

Terry J. Reedy added the comment: I have a 27" 2560X1440 screen. For me: >>> import tkinter; tkinter.Tk().tk.call('tk', 'scaling') 1.333... I presume 3200x200 should be 3200x2000 and that the diagonal size is small enough that the screen is a HiDPI screen, making tk's scaling above 1.4, so