[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Yury Selivanov added the comment: New changeset 1c19d656a79a00f58361ceb61c0a6d1faf90c686 by Yury Selivanov in branch '3.8': bpo-38242: Revert "bpo-36889: Merge asyncio streams (GH-13251)" (#16482) (#16485) https://github.com/python/cpython/commit/1c19d656a79a00f58361ceb61c0a6d1faf90c686 --

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by Yury Selivanov : -- pull_requests: +16071 pull_request: https://github.com/python/cpython/pull/16485 ___ Python tracker ___ __

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Yury Selivanov added the comment: New changeset 6758e6e12a71ef5530146161881f88df1fa43382 by Yury Selivanov in branch 'master': bpo-38242: Revert "bpo-36889: Merge asyncio streams (GH-13251)" (#16482) https://github.com/python/cpython/commit/6758e6e12a71ef5530146161881f88df1fa43382 -

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by Yury Selivanov : -- pull_requests: +16067 pull_request: https://github.com/python/cpython/pull/16482 ___ Python tracker ___ __

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

miss-islington added the comment: New changeset b9bfe143d151d184615fa3890f78874c5d4ed4c6 by Miss Islington (bot) in branch '3.8': bpo-36889: Document Stream class and add docstrings (GH-14488) https://github.com/python/cpython/commit/b9bfe143d151d184615fa3890f78874c5d4ed4c6 --

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by miss-islington : -- pull_requests: +15708 pull_request: https://github.com/python/cpython/pull/16087 ___ Python tracker ___ __

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

miss-islington added the comment: New changeset d31b31516c71890e8735606aec1dbf2bfb8fd6be by Miss Islington (bot) (Xtreak) in branch 'master': bpo-36889: Document Stream class and add docstrings (GH-14488) https://github.com/python/cpython/commit/d31b31516c71890e8735606aec1dbf2bfb8fd6be

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by Thrlwiti : -- nosy: -THRlWiTi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by Thrlwiti : -- nosy: +THRlWiTi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by Karthikeyan Singaravelan : -- pull_requests: +14306 pull_request: https://github.com/python/cpython/pull/14488 ___ Python tracker ___

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by miss-islington : -- pull_requests: +14238 pull_request: https://github.com/python/cpython/pull/14422 ___ Python tracker ___ __

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by Andrew Svetlov : -- pull_requests: +14211 pull_request: https://github.com/python/cpython/pull/14397 ___ Python tracker ___ __

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Andrew Svetlov added the comment: Yes, Stream doc should be a combination of StreamReader and StreamWriter with small changes/additions. StreamReader and StreamWriter should be kept in the doc. Regarding docstrings: there is no strong requirement (we don't provide docstrings for all asyncio

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Karthikeyan Singaravelan added the comment: Sure, I think I missed it somehow though you mentioned it's around combining StreamReader and StreamWriter and to have appropriate signatures for the methods. I will try to raise a PR this week. I also realize there are no docstrings for the new fu

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Andrew Svetlov added the comment: Thanks, Karthikeyan! The only thing that needs to be documented is Stream class itself. Would you finish this job, please? -- ___ Python tracker ___

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

miss-islington added the comment: New changeset 7268fd0d212e870103ae052697b32ba54d3f6299 by Miss Islington (bot) in branch '3.8': bpo-36889: Document asyncio Stream and StreamServer (GH-14203) https://github.com/python/cpython/commit/7268fd0d212e870103ae052697b32ba54d3f6299 --

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by miss-islington : -- pull_requests: +14168 pull_request: https://github.com/python/cpython/pull/14349 ___ Python tracker ___ __

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Andrew Svetlov added the comment: New changeset 6793cce155f8875b10efd746cb0b34cb72263af7 by Andrew Svetlov (Xtreak) in branch 'master': bpo-36889: Document asyncio Stream and StreamServer (GH-14203) https://github.com/python/cpython/commit/6793cce155f8875b10efd746cb0b34cb72263af7 --

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by Karthikeyan Singaravelan : -- pull_requests: +14041 pull_request: https://github.com/python/cpython/pull/14203 ___ Python tracker ___

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Andrew Svetlov added the comment: Please keep it until new streams will be documented. -- ___ Python tracker ___ ___ Python-bugs-li

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

STINNER Victor added the comment: Can this issue be closed now? -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mail

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by Andrew Svetlov : -- pull_requests: +13674 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/13790 ___ Python tracker ___ __

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Michael Felt added the comment: hmm - i had just synced with master. must have just missed something since there is a strike-out through GH-13251. If so, please ignore. BBL. -- ___ Python tracker __

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Michael Felt added the comment: FYI: since: commit 23b4b697e5b6cc897696f9c0288c187d2d24bff2 Author: Andrew Svetlov Date: Mon May 27 22:56:22 2019 +0300 bpo-36889: Merge asyncio streams (GH-13251) https://bugs.python.org/issue36889 AIX bot 'hangs' during test_sendfile (test.test

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Kubilay Kocak added the comment: @Andrew That would be great, as having failing buildbots can hide new regressions that end up taking much longer to identify and fix as they are hidden, and is better for you than reverting implementation code -- _

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Andrew Svetlov added the comment: Wow! Thanks for the report. Internally it is pretty close to freebsd problem. The test is unstable, not asyncio code itself. The test uses future objects to synchronize client and server socket processing but looks like there are race conditions still. Please

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Karthikeyan Singaravelan added the comment: test_stream_shutdown_hung_task_prevents_cancellation was added as part of this issue. Seems to be a random error : https://ci.appveyor.com/project/python/cpython/builds/24901585 ==

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Andrew Svetlov added the comment: Thanks for letting me know. Investigating. BrokenPipeError is not related, I had a plan to fix such messages during the beta phase. -- ___ Python tracker __

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Kubilay Kocak added the comment: Seeing a test_ayncio failure on koobs-freebsd-current: Timeout (0:25:00)! Thread 0x000800abb000 (most recent call first): File "/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/selectors.py", line 558 in select File "/usr/home/buildbot/p

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

miss-islington added the comment: New changeset 23b4b697e5b6cc897696f9c0288c187d2d24bff2 by Miss Islington (bot) (Andrew Svetlov) in branch 'master': bpo-36889: Merge asyncio streams (GH-13251) https://github.com/python/cpython/commit/23b4b697e5b6cc897696f9c0288c187d2d24bff2 -- nosy

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by Ian Good : -- nosy: +icgood ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

Change by Andrew Svetlov : -- keywords: +patch pull_requests: +13162 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

New submission from Andrew Svetlov : The separation was a bad idea, sorry. Both classes are coupled too much. 1. Writer should know about the reader to make `drain()` work 2. Reader has no .close() method. The idea is: 1. Merge StreamReader and StreamWriter into just a Stream. 2. The Stream sh