[issue36728] Remove PyEval_ReInitThreads() from the public C API

STINNER Victor added the comment: New changeset c1f7262f7013074613805347db2276f8b5e0e3a4 by Victor Stinner in branch 'master': bpo-36728: Remove PyEval_ReInitThreads documentation (GH-13282) https://github.com/python/cpython/commit/c1f7262f7013074613805347db2276f8b5e0e3a4 -- __

[issue36728] Remove PyEval_ReInitThreads() from the public C API

Change by STINNER Victor : -- pull_requests: +13189 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36728] Remove PyEval_ReInitThreads() from the public C API

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue36728] Remove PyEval_ReInitThreads() from the public C API

STINNER Victor added the comment: New changeset d5d9e81ce9a7efc5bc14a5c21398d1ef6f626884 by Victor Stinner in branch 'master': bpo-36728: Remove PyEval_ReInitThreads() from C API (GH-13241) https://github.com/python/cpython/commit/d5d9e81ce9a7efc5bc14a5c21398d1ef6f626884 -- ___

[issue36728] Remove PyEval_ReInitThreads() from the public C API

STINNER Victor added the comment: > i double checked in our massive internal codebase at work and found no calls > other than python interpreters themselves. Thanks. It confirms what I understood using GitHub code search (see my initial message). --

[issue36728] Remove PyEval_ReInitThreads() from the public C API

Gregory P. Smith added the comment: fwiw - i agree that this can be removed. it has no reason to ever be called directly. i double checked in our massive internal codebase at work and found no calls other than python interpreters themselves. -- nosy: +gregory.p.smith _

[issue36728] Remove PyEval_ReInitThreads() from the public C API

STINNER Victor added the comment: The function was added 19 years ago: commit fee3a2dd8cf984b8261032086fe513bf7327b601 Author: Guido van Rossum Date: Sun Aug 27 17:34:07 2000 + Charles Waldman's patch to reinitialize the interpreter lock after a fork. This solves the test_fork

[issue36728] Remove PyEval_ReInitThreads() from the public C API

Change by STINNER Victor : -- keywords: +patch pull_requests: +13151 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue36728] Remove PyEval_ReInitThreads() from the public C API

New submission from STINNER Victor : PyEval_ReInitThreads() is used internally by PyOS_AfterFork_Child(). I don't see the point of calling it directly. If you care of threads after fork, just call PyOS_AfterFork_Child(), no? I propose to remove PyEval_ReInitThreads() from the public C API. P