[issue36634] venv: activate.bat fails for venv with parentheses in PATH

miss-islington added the comment: New changeset 8a19a91e28b86592ee1ad9d1761e59b30d8511b9 by Miss Islington (bot) in branch '3.7': bpo-36634: Fixes activate.bat when existing values contain double quotes (GH-15924) https://github.com/python/cpython/commit/8a19a91e28b86592ee1ad9d1761e59b30d851

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

miss-islington added the comment: New changeset 20f80bfc83506037e40d918fcac887cee9093c93 by Miss Islington (bot) in branch '3.8': bpo-36634: Fixes activate.bat when existing values contain double quotes (GH-15924) https://github.com/python/cpython/commit/20f80bfc83506037e40d918fcac887cee9093

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

Change by miss-islington : -- pull_requests: +15602 pull_request: https://github.com/python/cpython/pull/15969 ___ Python tracker ___ __

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

Change by miss-islington : -- pull_requests: +15601 pull_request: https://github.com/python/cpython/pull/15968 ___ Python tracker ___ __

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

Zachary Ware added the comment: New changeset 574b324bdc9a126b5a4488c3613f11ad2555415e by Zachary Ware (Steve Dower) in branch 'master': bpo-36634: Fixes activate.bat when existing values contain double quotes (GH-15924) https://github.com/python/cpython/commit/574b324bdc9a126b5a4488c3613f11

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

Change by Steve Dower : -- pull_requests: +15564 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15924 ___ Python tracker ___ _

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

Change by Steve Dower : -- assignee: -> steve.dower versions: +Python 3.8, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list m

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

Steve Dower added the comment: We should be able to use alternate characters in the SET call, or just drop the quotes completely. In theory they make sense, but there's no trailing whitespace to worry about here. -- ___ Python tracker

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

Eryk Sun added the comment: > my user path contains a stray double quotation mark (") Steve, do you think we should work around this by first removing double quote characters from PATH? This will fix the user's PATH, making one or more directories searchable again, but it could have side eff

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

Bastian Wenzel added the comment: Ok I think I found my problem. The system path of of my machine is ok but my user path contains a stray double quotation mark (") like this: C:\Program Files\Git\bin";C:\Tools\antlr;C:\Program Files (x86)\Common Files\Oracle\Java\javapath ... With this I am

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

Bastian Wenzel added the comment: So if I replace this section from venv's activate.bat: if defined _OLD_VIRTUAL_PATH ( set "PATH=%_OLD_VIRTUAL_PATH%" ) else ( set "_OLD_VIRTUAL_PATH=%PATH%" ) with the part from virtualenv's activate.bat: REM if defined _OLD_VIRTUAL_PATH ( if not defi

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

Bastian Wenzel added the comment: I have attached the activate.bat script that got generated by venv. My current path looks like this (added line breaks for readability): C:\Program Files\Git\bin; C:\Tools\antlr; C:\Program Files (x86)\Common Files\Oracle\Java\javapath; C:\ProgramData\Oracle\

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

Steve Dower added the comment: Basically everyone has that directory in their PATH - we'd be hearing a lot more issues if it were a consistent bug. Can you share the full contents of your activate.bat file? And if it's okay, your full PATH variable (before and after running activate.bat) (Y

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

Change by Karthikeyan Singaravelan : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___ __

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

New submission from Bastian Wenzel : After creating a virtual environment on win 7 (64bit) with: py -3.7 -m venv venv Running venv\Scripts\activate.bat will yield this result: \Common was unexpected at this time. (venv) C:\... My PATH variable contains a path that starts with: C:\Program Files