[issue36370] Check for PyErr_Occurred() after PyImport_GetModule().

Stefan Krah added the comment: It looks like 3.6 is in security-fix only mode, so it cannot be backported there. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 -Python 3.6 ___ Python tracker <

[issue36370] Check for PyErr_Occurred() after PyImport_GetModule().

Stefan Krah added the comment: New changeset cdd8d4d6dd57f4c9429566706009d4613277d391 by Stefan Krah (Miss Islington (bot)) in branch '3.7': bpo-36370: Check for PyErr_Occurred() after PyImport_GetModule() (GH-12504) https://github.com/python/cpython/commit/cdd8d4d6dd57f4c9429566706009d461327

[issue36370] Check for PyErr_Occurred() after PyImport_GetModule().

Change by miss-islington : -- pull_requests: +12488 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36370] Check for PyErr_Occurred() after PyImport_GetModule().

Stefan Krah added the comment: New changeset 027b09c5a13aac9e14a3b43bb385298d549c3833 by Stefan Krah in branch 'master': bpo-36370: Check for PyErr_Occurred() after PyImport_GetModule() (GH-12504) https://github.com/python/cpython/commit/027b09c5a13aac9e14a3b43bb385298d549c3833 --

[issue36370] Check for PyErr_Occurred() after PyImport_GetModule().

Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue36370] Check for PyErr_Occurred() after PyImport_GetModule().

Change by Stefan Krah : -- keywords: +patch pull_requests: +12454 stage: needs patch -> patch review ___ Python tracker ___ ___ Pyth

[issue36370] Check for PyErr_Occurred() after PyImport_GetModule().

Stefan Krah added the comment: Actually I just see that this behavior of PyImport_GetModule() is documented: "Return the already imported module with the given name. If the module has not been imported yet then returns NULL but does not set an error. Returns NULL and sets an error if the loo

[issue36370] Check for PyErr_Occurred() after PyImport_GetModule().

Brett Cannon added the comment: Pulling in Eric and Nick as they have played w/ the C API more recently. -- nosy: +eric.snow, ncoghlan ___ Python tracker ___ _

[issue36370] Check for PyErr_Occurred() after PyImport_GetModule().

Change by Stefan Krah : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue36370] Check for PyErr_Occurred() after PyImport_GetModule().

Stefan Krah added the comment: The issue is that PyImport_GetModule() can legitimately NULL (not found) but also NULL after an error occurred in PyDict_GetItemWithError(). So one (quick and dirty) approach that fixes this abort() is: diff --git a/Python/import.c b/Python/import.c index bf3a99