[issue3633] float.fromhex discrepancy under Solaris

Mark Dickinson added the comment: A postscript: looking back at this from afar, the original error was almost certainly due to a missing Py_CHARMASK around the arguments to isdigit and isxdigit, and nothing to do with Unicode fullwidth digits at all. -- _

[issue3633] float.fromhex discrepancy under Solaris

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: The buildbot is still failing, but not on test_math. -- status: pending -> closed ___ Python tracker <[EMAIL PROTECTED]> __

[issue3633] float.fromhex discrepancy under Solaris

Mark Dickinson <[EMAIL PROTECTED]> added the comment: Thanks, Antoine. Committed, r65964 (2.6) and r65965 (3.0). Setting status to pending; will close if/when the Solaris buildbot goes green. -- resolution: -> fixed status: open -> pending ___ Py

[issue3633] float.fromhex discrepancy under Solaris

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Le jeudi 21 août 2008 à 21:26 +, Mark Dickinson a écrit : > Here's a patch. I'm reasonably confident that this should fix the > problem, but I don't have a Solaris machine to test it on. > > If anyone can check this on Solaris that woul

[issue3633] float.fromhex discrepancy under Solaris

Changes by Mark Dickinson <[EMAIL PROTECTED]>: -- keywords: +needs review ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-lis

[issue3633] float.fromhex discrepancy under Solaris

Mark Dickinson <[EMAIL PROTECTED]> added the comment: ...and here's the actual patch! Added file: http://bugs.python.org/file11199/issue3633.patch ___ Python tracker <[EMAIL PROTECTED]> __

[issue3633] float.fromhex discrepancy under Solaris

Mark Dickinson <[EMAIL PROTECTED]> added the comment: Here's a patch. I'm reasonably confident that this should fix the problem, but I don't have a Solaris machine to test it on. If anyone can check this on Solaris that would be fantastic, but I'll settle for a 'looks okay to me' from another

[issue3633] float.fromhex discrepancy under Solaris

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Le jeudi 21 août 2008 à 21:12 +, Mark Dickinson a écrit : > For now, it just seems simplest to replace the isxdigit call with an > explicit check for the ASCII 7-bit characters '0' through '9', 'a' > through 'f'. +1 I don't think it mak

[issue3633] float.fromhex discrepancy under Solaris

Mark Dickinson <[EMAIL PROTECTED]> added the comment: The problem appears to be that on Solaris, the isxdigit function (which is supposed to check whether a character is a valid hex digit) returns true for Unicode fullwidth digits. On other systems I have access to, isxdigit just returns true

[issue3633] float.fromhex discrepancy under Solaris

Mark Dickinson <[EMAIL PROTECTED]> added the comment: Thanks, Benjamin! Change to test committed in r65958, merged to py3k in r65959. Time to watch the py3k solaris buildbot. -- keywords: -needs review ___ Python tracker <[EMAIL PROTECTED]>

[issue3633] float.fromhex discrepancy under Solaris

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: That looks fine. ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing

[issue3633] float.fromhex discrepancy under Solaris

Mark Dickinson <[EMAIL PROTECTED]> added the comment: Here's a patch for the test-suite to get more information about where float.fromhex is failing. Could someone else please review this quickly so that I can check it in? It shouldn't take more than a few minutes to review. -- keyw

[issue3633] float.fromhex discrepancy under Solaris

Mark Dickinson <[EMAIL PROTECTED]> added the comment: I'll take a look, though if anyone has some time to spare and access to a Solaris machine then they can probably figure this out more quickly. The first step would be to fix the test so that it at least shows which input the failure occurs

[issue3633] float.fromhex discrepancy under Solaris

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: This probably has been happening for quite a while. We just didn't notice because that bot was busy hanging on test_nis. The failure is in test_math. Mark, do you know anything? -- nosy: +benjamin.peterson, marketdickinson __

[issue3633] float.fromhex discrepancy under Solaris

New submission from Antoine Pitrou <[EMAIL PROTECTED]>: This is a failure that seems to occur quite often (always?) on the Solaris buildbot: == FAIL: test_invalid_inputs (test.test_float.HexFloatTestCase) ---