[issue36106] resolve sinpi() name clash with libm

Cheryl Sabella added the comment: I'll nosy Ned as the release manager about the request to 3.6. -- nosy: +cheryl.sabella, ned.deily ___ Python tracker ___ ___

[issue36106] resolve sinpi() name clash with libm

Dmitrii Pasechnik added the comment: Can this also be backported to 3.5. and 3.6, as requested by FreeBSD maintainers? -- ___ Python tracker ___ _

[issue36106] resolve sinpi() name clash with libm

Mark Dickinson added the comment: This one was my fault. Thanks for the fix! -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue36106] resolve sinpi() name clash with libm

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue36106] resolve sinpi() name clash with libm

Serhiy Storchaka added the comment: New changeset b545ba0a508a5980ab147ed2641a42be3b31a2db by Serhiy Storchaka (Dima Pasechnik) in branch '2.7': [2.7] bpo-36106: resolve sinpi name clash with libm (IEEE-754 violation). (GH-12027) (GH-12050) https://github.com/python/cpython/commit/b545ba0a50

[issue36106] resolve sinpi() name clash with libm

Change by Dmitrii Pasechnik : -- pull_requests: +12076 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue36106] resolve sinpi() name clash with libm

Kubilay Kocak added the comment: Downstream issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232792 -- nosy: +koobs versions: +Python 2.7, Python 3.8 ___ Python tracker __

[issue36106] resolve sinpi() name clash with libm

miss-islington added the comment: New changeset 4e6646fef5d2cc53422e4eca0b18201ed5a5c4b6 by Miss Islington (bot) in branch '3.7': bpo-36106: Resolve sinpi name clash with libm (IEEE-754 violation). (GH-12027) https://github.com/python/cpython/commit/4e6646fef5d2cc53422e4eca0b18201ed5a5c4b6

[issue36106] resolve sinpi() name clash with libm

Change by miss-islington : -- keywords: +patch pull_requests: +12071 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue36106] resolve sinpi() name clash with libm

Serhiy Storchaka added the comment: New changeset f57cd8288dbe6aba99c057f37ad6d58f8db75350 by Serhiy Storchaka (Dima Pasechnik) in branch 'master': bpo-36106: Resolve sinpi name clash with libm (IEEE-754 violation). (GH-12027) https://github.com/python/cpython/commit/f57cd8288dbe6aba99c057f37

[issue36106] resolve sinpi() name clash with libm

Change by Emmanuel Arias : -- nosy: +eamanu ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue36106] resolve sinpi() name clash with libm

Dmitrii Pasechnik added the comment: e.g. if I rename `m_lgamma` to `lgamma` I get ``` mathmodule.c:389:1: error: static declaration of ‘lgamma’ follows non-static declaration lgamma(double x) ``` -- ___ Python tracker

[issue36106] resolve sinpi() name clash with libm

Dmitrii Pasechnik added the comment: This has a potential header conflict. For the same reason functions like lgamma, etc. are prefixed with `m_` in Modules/mathmodule.c -- ___ Python tracker ___

[issue36106] resolve sinpi() name clash with libm

Emmanuel Arias added the comment: Hi!, It seem a good improve to resolve a potential problem. But I am not convinced if that problem could appear because sinpi() is definded locally. -- ___ Python tracker ___

[issue36106] resolve sinpi() name clash with libm

Change by SilentGhost : -- nosy: +mark.dickinson stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue36106] resolve sinpi() name clash with libm

New submission from Dmitrii Pasechnik : The standard math library (libm) may follow IEEE-754 recommendation to include an implementation of sinPi(), i.e. sinPi(x):=sin(pi*x). And this triggers a name clash, found by FreeBSD developer Steve Kargl, who worken on putting sinpi into libm used on Fre