[issue3605] Py_FatalError causes infinite loop

STINNER Victor added the comment: New changeset d12d0e7c0fe2b49c40ac4d66365147c619d6c475 by Victor Stinner in branch 'master': bpo-38733: PyErr_Occurred() caller must hold the GIL (GH-17080) https://github.com/python/cpython/commit/d12d0e7c0fe2b49c40ac4d66365147c619d6c475 -- __

[issue3605] Py_FatalError causes infinite loop

Change by STINNER Victor : -- pull_requests: +16590 pull_request: https://github.com/python/cpython/pull/17080 ___ Python tracker ___ ___

[issue3605] Py_FatalError causes infinite loop

Changes by Ralf Schmitt : -- nosy: +schmir ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue3605] Py_FatalError causes infinite loop

Neil Aspinall added the comment: Would it be possible for this issue's fix (PyErr_Occurred() returning null when the thread state is null) to be applied to the 2.7 branch? -- nosy: +naspinal ___ Python tracker ___

[issue3605] Py_FatalError causes infinite loop

Roger Upole added the comment: I know this has been closed, but I disagree with the fix. Py_FatalError is designed to give a clean exit with a readable error message when the state of the interpreter is known to be compromised. Calling *any* python functions or accessing *any* python interna

[issue3605] Py_FatalError causes infinite loop

STINNER Victor added the comment: I fixed the new test for Windows: r81183 (py3k). The new test failed on Windows because of the different newline characters: Traceback (most recent call last): File "...\test_capi.py", line 49, in test_no_FatalError_infinite_loop b'Fatal Python error:' A

[issue3605] Py_FatalError causes infinite loop

Jeffrey Yasskin added the comment: Fixed in r81142. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue3605] Py_FatalError causes infinite loop

Jeffrey Yasskin added the comment: I have a fix at http://codereview.appspot.com/1184043, which makes PyErr_Occurred() return NULL when there is no thread. I'll commit it tomorrow unless there are comments. -- assignee: -> jyasskin keywords: +needs review nosy: +jyasskin stage: unit

[issue3605] Py_FatalError causes infinite loop

Changes by lekma : -- nosy: +lekma ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailma

[issue3605] Py_FatalError causes infinite loop

Changes by Daniel Diniz : -- priority: -> normal stage: -> test needed type: -> behavior versions: +Python 3.1 -Python 3.0 ___ Python tracker ___ __

[issue3605] Py_FatalError causes infinite loop

Changes by Daniel Diniz <[EMAIL PROTECTED]>: -- nosy: +ajaksu2 ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing l

[issue3605] Py_FatalError causes infinite loop

Roger Upole <[EMAIL PROTECTED]> added the comment: Well, you asked for a simple case. In practice, I'm dealing with much more complicated code that contains callbacks which may need to acquire or release the theadlock. This problem makes it very difficult to debug such code. Also, the PyErr_O

[issue3605] Py_FatalError causes infinite loop

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > Roger Upole <[EMAIL PROTECTED]> added the comment: > > Py_BEGIN_ALLOW_THREADS > PyErr_SetString(PyExc_SystemError, "bork bork bork"); > Py_END_ALLOW_THREADS Well, if you start using all kinds of internal APIs without holding th

[issue3605] Py_FatalError causes infinite loop

Roger Upole <[EMAIL PROTECTED]> added the comment: Py_BEGIN_ALLOW_THREADS PyErr_SetString(PyExc_SystemError, "bork bork bork"); Py_END_ALLOW_THREADS ___ Python tracker <[EMAIL PROTECTED]> _

[issue3605] Py_FatalError causes infinite loop

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Do you have a simple code sample to showcase that? -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3605] Py_FatalError causes infinite loop

New submission from Roger Upole <[EMAIL PROTECTED]>: Py_FatalError calls PyErr_Occurred() which requires a current thread state. This mean that if the original error was a thread state error Py_FatalError is triggered again, ad infinitum. -- components: Interpreter Core messages: 71478