[issue35854] EnvBuilder and venv symlinks do not work on Windows on 3.7.2

2019-03-12 Thread Steve Dower
Steve Dower added the comment: Yep. Done -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue35854] EnvBuilder and venv symlinks do not work on Windows on 3.7.2

2019-03-11 Thread Ned Deily
Ned Deily added the comment: Can we close this issue now? -- nosy: +ned.deily ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue35854] EnvBuilder and venv symlinks do not work on Windows on 3.7.2

2019-01-30 Thread miss-islington
miss-islington added the comment: New changeset 03082a836b707528f885080bda9732d89849d4e3 by Miss Islington (bot) in branch '3.7': bpo-35854: Fix EnvBuilder and --symlinks in venv on Windows (GH-11700) https://github.com/python/cpython/commit/03082a836b707528f885080bda9732d89849d4e3

[issue35854] EnvBuilder and venv symlinks do not work on Windows on 3.7.2

2019-01-30 Thread Steve Dower
Steve Dower added the comment: New changeset a1f9a3332bd4767e47013ea787022f06b6dbcbbd by Steve Dower in branch 'master': bpo-35854: Fix EnvBuilder and --symlinks in venv on Windows (GH-11700) https://github.com/python/cpython/commit/a1f9a3332bd4767e47013ea787022f06b6dbcbbd -- pull_r

[issue35854] EnvBuilder and venv symlinks do not work on Windows on 3.7.2

2019-01-30 Thread Eryk Sun
Eryk Sun added the comment: > Okay, testing more thoroughly on 3.5, symlinks are fine from the > console but not via Explorer. I gave up on using EXE symlinks with Explorer and ShellExecute[Ex]. The shell handles symlinks like shortcuts instead of leaving it up to the file system. In Window

[issue35854] EnvBuilder and venv symlinks do not work on Windows on 3.7.2

2019-01-30 Thread Steve Dower
Steve Dower added the comment: Okay, testing more thoroughly on 3.5, symlinks are fine from the console but not via Explorer. Personally, I dislike that double-clicking python.exe is different from running it from the command line, but so be it. I'll add a note to the docs that this doesn't

[issue35854] EnvBuilder and venv symlinks do not work on Windows on 3.7.2

2019-01-30 Thread Steve Dower
Steve Dower added the comment: No, removing it was accidental. But when I tried it myself with a few regular installs of 3.5 and later, none of them updated sys.path correctly, and all of them resolved the links in the loader (or perhaps the shell?). I hadn't activated the environments, as I

[issue35854] EnvBuilder and venv symlinks do not work on Windows on 3.7.2

2019-01-29 Thread Eryk Sun
Eryk Sun added the comment: > Actually, it seems like venv symlinks are so far from working > that they haven't worked (on Windows) since 3.5 or possibly > earlier. I use venv with --symlinks prior to 3.7.2. It works fine as far as I can tell. Perhaps you could elaborate. I assumed you remo

[issue35854] EnvBuilder and venv symlinks do not work on Windows on 3.7.2

2019-01-29 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch, patch, patch pull_requests: +11548, 11549, 11550 stage: -> patch review ___ Python tracker ___ ___

[issue35854] EnvBuilder and venv symlinks do not work on Windows on 3.7.2

2019-01-29 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch, patch pull_requests: +11548, 11549 stage: -> patch review ___ Python tracker ___ ___ P

[issue35854] EnvBuilder and venv symlinks do not work on Windows on 3.7.2

2019-01-29 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +11548 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue35854] EnvBuilder and venv symlinks do not work on Windows on 3.7.2

2019-01-29 Thread Steve Dower
Steve Dower added the comment: Actually, it seems like venv symlinks are so far from working that they haven't worked (on Windows) since 3.5 or possibly earlier. I'm just going to make that option ignored and mark it as such in the docs. -- ___ Py

[issue35854] EnvBuilder and venv symlinks do not work on Windows on 3.7.2

2019-01-29 Thread Steve Dower
New submission from Steve Dower : The change to pull the redirector executables as part of scripts was... perhaps too clever. There exists code out there that uses EnvBuilder to create environments _without_ copying scripts, which now results in an environment that does not include python.exe