[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Change by Steve Dower : -- assignee: -> steve.dower resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

miss-islington added the comment: New changeset a6a8524bb1c78c7425346ec20ecffc02d1d02a79 by Miss Islington (bot) in branch '3.7': bpo-35811: Avoid propagating venv settings when launching via py.exe (GH-11677) https://github.com/python/cpython/commit/a6a8524bb1c78c7425346ec20ecffc02d1d02a79

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Change by miss-islington : -- pull_requests: +11506, 11507, 11508 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Change by miss-islington : -- pull_requests: +11506 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Change by miss-islington : -- pull_requests: +11506, 11507 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Steve Dower added the comment: New changeset adad9e68013aac166c84ffe4e23f3a5464f41840 by Steve Dower in branch 'master': bpo-35811: Avoid propagating venv settings when launching via py.exe (GH-11677) https://github.com/python/cpython/commit/adad9e68013aac166c84ffe4e23f3a5464f41840

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Change by Steve Dower : -- keywords: +patch, patch, patch pull_requests: +11500, 11501, 11502 stage: test needed -> patch review ___ Python tracker ___

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Change by Steve Dower : -- keywords: +patch pull_requests: +11500 stage: test needed -> patch review ___ Python tracker ___ ___ Pyth

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Change by Steve Dower : -- keywords: +patch, patch pull_requests: +11500, 11501 stage: test needed -> patch review ___ Python tracker ___ __

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Steve Dower added the comment: I think that snippet may have to change to accommodate the multiprocessing issue, where we need to stop replacing sys.executable with the venv launcher and have it point to the base python.exe (and then anyone launching sys.executable needs to preserve __PYVENV

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Eryk Sun added the comment: > But if I understood what Steve said, only if path\to\python.exe is > a *relative* pathname? I believe Steve is referring to behavior changes for applications that relied on a virtual environment's "Scripts" directory always being in the EXE and default DLL and

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Paul Moore added the comment: > The script executable redirects to run `"path\to\python.exe" > "path\to\.exe"`. But if I understood what Steve said, only if path\to\python.exe is a *relative* pathname? -- ___ Python tracker

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Eryk Sun added the comment: > 1. Is there a possibility that 3rd party applications like pip > could see bugs with Python 3.7.2? A bug occurs when running an entry-point script, such as pip.exe, for a system- or user-installed Python 3.7.2+ from the context of a virtual environment for 3.7.

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Paul Moore added the comment: Steve - thanks for the clarification. If it's only affecting launching with relative paths, then agreed it's minor (although I do recall recent discussions somewhere about using launchers with relative paths - that use case may need checking, but we can deal wit

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Steve Dower added the comment: It might be worth adding a summary of that to the porting notes, but I think the actual impact will be minimal. Launching processes by relative path has been a bad decision for long enough now that I'd expect it to be rare, and the Scripts directory layout bein

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Paul Moore added the comment: I'm not particularly happy with the statement that "However, the latter is out of scope here since the entry-point launchers are in distlib." If Python is changing the semantics of __PYVENV_LAUNCHER__ in such a way that it breaks 3rd party code, it seems to me t

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Eryk Sun added the comment: It's worth noting the consequences of changing the application directory (i.e. the "%__APPDIR__%" dynamic variable from GetEnvironmentVariableW). This is the first directory checked in most cases when Windows searches for a file, including the CreateProcess[AsUser]

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

Steve Dower added the comment: FWIW, a symlink should be able to launch the Store Python - the problem with the old approach was it never tried to launch the original Python, but only load it's DLLs which won't work (maybe there's a way to enable the app context, but that would still require

[issue35811] py.exe should unset the __PYVENV_LAUNCHER__ environment variable

New submission from Eryk Sun : In 3.7.2 on Windows, venv now uses a redirecting launcher 'script' for python[w].exe. This replaces (on Windows only) the setup requirement to copy or symlink the interpreter binaries (i.e. python[w].exe, python37.dll, and vcruntime140.dll). Apparently this is r