[issue35749] Rewrite asyncio signal handler

Alan Jenkins added the comment: Here's a simple test case that fails on the main branch. https://github.com/sourcejedi/cpython/commit/50184ea3b354fd775866d036ccee058ec6734927 > the patch assumes that python signal handler will be called *before* reading > from self-pipe. > Otherwise, a sign

[issue35749] Rewrite asyncio signal handler

Change by Yury Selivanov : -- stage: resolved -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35749] Rewrite asyncio signal handler

Yury Selivanov added the comment: > You are right, the issue is "theoretical", I didn't see problems with current > implementation. > The self-pipe buffer is pretty big, a chance to reach its limit is relatively > low. Actually, I disagree. The problem manifests itself easily when you orche

[issue35749] Rewrite asyncio signal handler

Change by Andrew Svetlov : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue35749] Rewrite asyncio signal handler

Andrew Svetlov added the comment: Victor, thanks for the message. I forgot mentioned changes. You are right, the issue is "theoretical", I didn't see problems with current implementation. The self-pipe buffer is pretty big, a chance to reach its limit is relatively low. But a change to break

[issue35749] Rewrite asyncio signal handler

STINNER Victor added the comment: In short, attached PR reverts the following commit: commit fe5649c7b7bf52147480d6b1124a3d8e3597aee3 Author: Victor Stinner Date: Thu Jul 17 22:43:40 2014 +0200 Python issue #21645, Tulip issue 192: Rewrite signal handling Since Python 3.3, the