[issue35742] test_builtin fails after merging the fix for bpo-34756

2019-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Maybe CI updates only files touched by the PR and the failed test was added after the initial creation of the PR? Or there is something wrong with timestamps, so outdated pyc files were used for tests? -- ___ Py

[issue35742] test_builtin fails after merging the fix for bpo-34756

2019-01-15 Thread STINNER Victor
STINNER Victor added the comment: > I was surprised too. Maybe it is because that was very old PR. Yeah, that's the most likely explanation. Maybe the CI ran tests before the final merge, or something like that? It doesn't explain why buildbots didn't complain, but it doesn't matter if such

[issue35742] test_builtin fails after merging the fix for bpo-34756

2019-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I was surprised too. Maybe it is because that was very old PR. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue35742] test_builtin fails after merging the fix for bpo-34756

2019-01-15 Thread miss-islington
miss-islington added the comment: New changeset 97d6a56d9d169f35cf2a24d62bf15adfc42fc672 by Miss Islington (bot) in branch '3.7': bpo-35742: Fix test_envar_unimportable in test_builtin. (GH-11561) https://github.com/python/cpython/commit/97d6a56d9d169f35cf2a24d62bf15adfc42fc672 -- n

[issue35742] test_builtin fails after merging the fix for bpo-34756

2019-01-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 3607ef43c4a1a24d44f39ff54a77fc0af5bfa09a by Serhiy Storchaka in branch 'master': bpo-35742: Fix test_envar_unimportable in test_builtin. (GH-11561) https://github.com/python/cpython/commit/3607ef43c4a1a24d44f39ff54a77fc0af5bfa09a --

[issue35742] test_builtin fails after merging the fix for bpo-34756

2019-01-15 Thread STINNER Victor
STINNER Victor added the comment: > Found a test_builtin failure in the job for the relevant commit on Travis CI > - https://travis-ci.org/python/cpython/jobs/479642964#L1491. This job is for code coverage. I confirm that failures are allowed. This job runs the full test suite in sequence, w

[issue35742] test_builtin fails after merging the fix for bpo-34756

2019-01-15 Thread Chih-Hsuan Yen
Chih-Hsuan Yen added the comment: Found a test_builtin failure in the job for the relevant commit on Travis CI - https://travis-ci.org/python/cpython/jobs/479642964#L1491. I guess it's not noticed as it's listed in allow_failures in .travis.yml. However, I'm not sure if it's the same issue o

[issue35742] test_builtin fails after merging the fix for bpo-34756

2019-01-15 Thread STINNER Victor
STINNER Victor added the comment: I don't understand why buildbots didn't scream and why the test didn't fail on Travis CI nor AppVeyor on https://github.com/python/cpython/pull/9457 -- nosy: +vstinner ___ Python tracker

[issue35742] test_builtin fails after merging the fix for bpo-34756

2019-01-15 Thread Chih-Hsuan Yen
Chih-Hsuan Yen added the comment: Wow that's super fast! I can confirm the patch fixes the issue on my machine. Thanks! -- ___ Python tracker ___

[issue35742] test_builtin fails after merging the fix for bpo-34756

2019-01-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch, patch, patch pull_requests: +11202, 11203, 11204 stage: -> patch review ___ Python tracker ___ __

[issue35742] test_builtin fails after merging the fix for bpo-34756

2019-01-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch, patch, patch, patch pull_requests: +11202, 11203, 11204, 11205 stage: -> patch review ___ Python tracker ___

[issue35742] test_builtin fails after merging the fix for bpo-34756

2019-01-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch, patch pull_requests: +11202, 11203 stage: -> patch review ___ Python tracker ___

[issue35742] test_builtin fails after merging the fix for bpo-34756

2019-01-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +11202 stage: -> patch review ___ Python tracker ___ ___ Python-bug

[issue35742] test_builtin fails after merging the fix for bpo-34756

2019-01-15 Thread Chih-Hsuan Yen
New submission from Chih-Hsuan Yen : On git-master (32ebd8508d4807a7c85d2ed8e9c3b44ecd6de591) of CPython, 3 tests of test_builtin fails: == ERROR: test_envar_unimportable (test.test_builtin.TestBreakpoint) (envar='.')