[issue35730] IDLE: Fix squeezer test_reload.

Terry J. Reedy added the comment: I looked at the non-green results on the buildbot grid and found one IDLE failure, which passed on retest. I opened #35771 for this. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- pull_requests: -11322 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- pull_requests: -11321 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35730] IDLE: Fix squeezer test_reload.

miss-islington added the comment: New changeset 237f864c905531b2da211bebc5f6109b0b797bac by Miss Islington (bot) in branch '3.7': bpo-35730: IDLE - test squeezer reload() by checking load_font() (GH-11585) https://github.com/python/cpython/commit/237f864c905531b2da211bebc5f6109b0b797bac ---

[issue35730] IDLE: Fix squeezer test_reload.

Change by miss-islington : -- pull_requests: +11320 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35730] IDLE: Fix squeezer test_reload.

Change by miss-islington : -- pull_requests: +11320, 11321, 11322 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35730] IDLE: Fix squeezer test_reload.

Terry J. Reedy added the comment: New changeset e55cf024cae203f63b4f78f1b21c1375fe424441 by Terry Jan Reedy (Tal Einat) in branch 'master': bpo-35730: IDLE - test squeezer reload() by checking load_font() (GH-11585) https://github.com/python/cpython/commit/e55cf024cae203f63b4f78f1b21c1375fe42

[issue35730] IDLE: Fix squeezer test_reload.

Change by miss-islington : -- pull_requests: +11320, 11321 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- pull_requests: -11274 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- pull_requests: -11273 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35730] IDLE: Fix squeezer test_reload.

Change by Tal Einat : -- pull_requests: +11272, 11273, 11274 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35730] IDLE: Fix squeezer test_reload.

Change by Tal Einat : -- pull_requests: +11272, 11273 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue35730] IDLE: Fix squeezer test_reload.

Change by Tal Einat : -- pull_requests: +11272 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- pull_requests: -11182 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- pull_requests: -11183 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- pull_requests: +11181, 11182 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- pull_requests: +11181 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- pull_requests: +11181, 11182, 11183 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35730] IDLE: Fix squeezer test_reload.

STINNER Victor added the comment: The test still pass on my Fedora 29 with: diff --git a/Lib/idlelib/idle_test/test_squeezer.py b/Lib/idlelib/idle_test/test_squeezer.py index 71eccd3693..e026567789 100644 --- a/Lib/idlelib/idle_test/test_squeezer.py +++ b/Lib/idlelib/idle_test/test_squeezer.p

[issue35730] IDLE: Fix squeezer test_reload.

Tal Einat added the comment: > What if the old and the new font have the same width? The font is set to Courier 10 in the test's setup, and it is then set to Courier 20 by the test before calling reload(). The zero character should certainly not have the same width in both cases. ISTM that

[issue35730] IDLE: Fix squeezer test_reload.

STINNER Victor added the comment: > Not really. This test, test_reload(), is specifically checking that the > reload() function updates zero_char_width after font changes. What if the old and the new font have the same width? -- ___ Python tracker

[issue35730] IDLE: Fix squeezer test_reload.

Tal Einat added the comment: > The test rely on a specific font name and specific font size: maybe this > specific font is not available. Can you help by checking this? Is there another font known to be universally available? > Instead of skipping the test, would it make same to accept that

[issue35730] IDLE: Fix squeezer test_reload.

STINNER Victor added the comment: https://buildbot.python.org/all/#/builders/108/builds/895/steps/5/logs/stdio https://buildbot.python.org/all/#/builders/115/builds/888/steps/4/logs/stdio == FAIL: test_reload (idlelib.idle_tes

[issue35730] IDLE: Fix squeezer test_reload.

Terry J. Reedy added the comment: The corresponding 3.7 buildbots failed the same way, 6 not greater than 6, as the 3.8 buildbots. https://buildbot.python.org/all/#/builders/108/builds/895/steps/5/logs/stdio https://buildbot.python.org/all/#/builders/115/builds/888/steps/4/logs/stdio One reas

[issue35730] IDLE: Fix squeezer test_reload.

Terry J. Reedy added the comment: I just realized that the Gentoo bots where this failed are, last I knew, the only *nix bots with X installed. The non-Windows CI bots run the gui tests with an X simulator. So Gentoo might not be the only distribution where this would fail. Two debug pri

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- pull_requests: -11157 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35730] IDLE: Fix squeezer test_reload.

miss-islington added the comment: New changeset 890d3fa10c68af6306cf6b989b2133978e6e7a12 by Miss Islington (bot) in branch '3.7': bpo-35730: Disable IDLE test_reload assertion. (GH-11543) https://github.com/python/cpython/commit/890d3fa10c68af6306cf6b989b2133978e6e7a12 -- nosy: +mis

[issue35730] IDLE: Fix squeezer test_reload.

Change by miss-islington : -- pull_requests: +11156 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35730] IDLE: Fix squeezer test_reload.

Change by miss-islington : -- pull_requests: +11156, 11157 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35730] IDLE: Fix squeezer test_reload.

Terry J. Reedy added the comment: New changeset 5bb146aaea1484bcc117ab6cb38dda39ceb5df0f by Terry Jan Reedy in branch 'master': bpo-35730: Disable IDLE test_reload assertion. (GH-11543) https://github.com/python/cpython/commit/5bb146aaea1484bcc117ab6cb38dda39ceb5df0f -- ___

[issue35730] IDLE: Fix squeezer test_reload.

Terry J. Reedy added the comment: Victor, a particular test assert fails only on Gentoo bots (see above). Questions: 1. Can we disable the assert only on those machines? 2. I sometimes see what look like debug prints in buildbot test logs. Correct? If so, stdout or stderr? -- no

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- pull_requests: -11155 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- pull_requests: -11154 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- keywords: +patch pull_requests: +11153 stage: needs patch -> patch review ___ Python tracker ___ ___ P

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- keywords: +patch, patch, patch pull_requests: +11153, 11154, 11155 stage: needs patch -> patch review ___ Python tracker ___ _

[issue35730] IDLE: Fix squeezer test_reload.

Change by Terry J. Reedy : -- keywords: +patch, patch pull_requests: +11153, 11154 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue35730] IDLE: Fix squeezer test_reload.

New submission from Terry J. Reedy : PR 10454 for #35196 added, among other things, more tests to test_squeezer.py. SqueezerTest.test_reload initially worked on Mac and personal Windows machines. It failed on Cheryl Sabella's personal Ubuntu machine because doubling the nominal font size did