[issue35697] _decimal: Implement the previously rejected changes from #7442.

2019-04-16 Thread STINNER Victor
STINNER Victor added the comment: I'm no longer interested to rewrite my patch to avoid _Py_GetLocaleconvNumeric() which comes from the internal API, so I close my PR. -- resolution: -> out of date stage: patch review -> resolved status: open -> closed __

[issue35697] _decimal: Implement the previously rejected changes from #7442.

2019-01-12 Thread Raymond Hettinger
Raymond Hettinger added the comment: > Sometimes not being dependent on API functions is a virtue if the code does > not change very often. That is a reasonable position to take. -- nosy: +rhettinger ___ Python tracker

[issue35697] _decimal: Implement the previously rejected changes from #7442.

2019-01-09 Thread Stefan Krah
Stefan Krah added the comment: I mean issue reports like #33954 or #35195. These are just two examples, and I'm NOT claiming that they are related. But if functions like _PyUnicode_InsertThousandsGrouping() *were* used in _decimal, I'd feel compelled to investigate. Now I don't have to. I'd

[issue35697] _decimal: Implement the previously rejected changes from #7442.

2019-01-09 Thread STINNER Victor
STINNER Victor added the comment: Extract of Stefan Krah's msg333296 of bpo-35638: > So why would you think that I'm not aware of that issue? Oh, I never said that. I wrote "By the way, the decimal module doesn't support properly the following corner case: LC_NUMERIC using an encoding diffe

[issue35697] _decimal: Implement the previously rejected changes from #7442.

2019-01-09 Thread STINNER Victor
STINNER Victor added the comment: Oh, I forgot to mention the context: I reported this issue as follow-up to discussions on bpo-35638: "Introduce fixed point locale aware format type for floating point numbers". -- ___ Python tracker

[issue35697] _decimal: Implement the previously rejected changes from #7442.

2019-01-09 Thread STINNER Victor
STINNER Victor added the comment: Stefan Krah: > Don't you find it strange to close #7442 in mutual agreement and now mention the word "bug" 50 times? We agreed to close the bug in 2014. In the meanwhile, more and more people reported the same bug (multiple similar bug reports and more and mo

[issue35697] _decimal: Implement the previously rejected changes from #7442.

2019-01-09 Thread Stefan Krah
Stefan Krah added the comment: Also Marc-Andre does not consider this a bug in #31900. The presentation of this issue is increasingly bizarre. -- ___ Python tracker ___ _

[issue35697] _decimal: Implement the previously rejected changes from #7442.

2019-01-09 Thread Stefan Krah
Change by Stefan Krah : -- title: decimal: formatter error if LC_NUMERIC uses a different encoding than LC_CTYPE -> _decimal: Implement the previously rejected changes from #7442. ___ Python tracker