[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Change by Cheryl Sabella : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Michael Felt added the comment: I did not ask back in June - but could this also be backported to 3.7. I am trying very hard to have all tests also passing on 3.7. as @asvetlov is ok with a skipped test for AIX - see https://bugs.python.org/issue35545#msg344003 I can make the backport, if ne

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Change by Sascha Silbe : -- nosy: +sascha_silbe ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Zaar Hai added the comment: Good day guys, Does anyone have an idea if it's going to be fixed for 3.8? -- nosy: +Zaar Hai ___ Python tracker ___ __

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

miss-islington added the comment: New changeset 70a4178ec47154fdcc3ff06c13149e178d014581 by Miss Islington (bot) in branch '3.8': bpo-35545: Skip `test_asyncio.test_create_connection_ipv6_scope` on AIX (GH-14011) https://github.com/python/cpython/commit/70a4178ec47154fdcc3ff06c13149e178d0145

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

miss-islington added the comment: New changeset 32dda263e4e8c8e0fadc2bb29b9856e2f177dde9 by Miss Islington (bot) (Michael Felt) in branch 'master': bpo-35545: Skip `test_asyncio.test_create_connection_ipv6_scope` on AIX (GH-14011) https://github.com/python/cpython/commit/32dda263e4e8c8e0fadc

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Change by miss-islington : -- pull_requests: +13876 pull_request: https://github.com/python/cpython/pull/14012 ___ Python tracker ___ __

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Change by Michael Felt : -- pull_requests: +13875 pull_request: https://github.com/python/cpython/pull/14011 ___ Python tracker ___

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Michael Felt added the comment: On 30/05/2019 23:11, Andrew Svetlov wrote: > Andrew Svetlov added the comment: > > Guys, thank you for investigation. > If there is AIX "idiosyncrasy" -- please feel free to skip failed tests on > AIX. > > If you have access to AIX box it would be much easier f

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Andrew Svetlov added the comment: Guys, thank you for investigation. If there is AIX "idiosyncrasy" -- please feel free to skip failed tests on AIX. If you have access to AIX box it would be much easier for you. I can only look at Python buildbot statuses. -- ___

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Michael Felt added the comment: On 30/05/2019 10:27, Erwan Le Pape wrote: > Erwan Le Pape added the comment: > > Assuming similar configuration to the one in msg343430, a simple native > getaddrinfo test to check whether any scope ID is returned. The 'expanded' program ... main(): int main()

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Erwan Le Pape added the comment: Assuming similar configuration to the one in msg343430, a simple native getaddrinfo test to check whether any scope ID is returned. ``` #include #include #include #include void test(char *addrstr) { int status; struct addrinfo *res; struct ad

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Michael Felt added the comment: On 25/05/2019 00:19, Erwan Le Pape wrote: > Erwan Le Pape added the comment: > > Thanks for testing that. It's good that you used an actual address because > that eliminates the possibility that AIX doesn't handle addresses it doesn't > really know about. > > O

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Michael Felt added the comment: No problem with trying out your tests. Sent from my iPhone > On 25 May 2019, at 00:19, Erwan Le Pape wrote: > > > Erwan Le Pape added the comment: > > Thanks for testing that. It's good that you used an actual address because > that eliminates the possib

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Erwan Le Pape added the comment: Thanks for testing that. It's good that you used an actual address because that eliminates the possibility that AIX doesn't handle addresses it doesn't really know about. On the other hand, even when properly specified to a real scoped IPv6 address, `getaddr

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Michael Felt added the comment: On 24/05/2019 19:59, Erwan Le Pape wrote: > python3 -c 'import socket; print(socket.getaddrinfo("fe80::1%1", 80))'` p.s. I used an actual address: buildbot@x064:[/home/buildbot/aixtools-master]netstat -ni Name  Mtu   Network Address    Ipkts Ierrs   

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Michael Felt added the comment: On 24/05/2019 19:59, Erwan Le Pape wrote: > python3 -c 'import socket; print(socket.getaddrinfo("fe80::1%1", 80))'` root@x067:[/home/root]python3 -c 'import socket; print(socket.getaddrinfo("fe80::1%1", 80))' [(, , 17, '', ('fe80::1', 80, 0, 0))] I have not yet

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Erwan Le Pape added the comment: I don't have an AIX lying around to test so would you mind just running the test on `getaddrinfo` for AIX. A simple `python3 -c 'import socket; print(socket.getaddrinfo("fe80::1%1", 80))'` should fairly rapidly determine if there is a legitimate reason for th

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Michael Felt added the comment: In hindsight, maybe the message could have been better, BUT - is it relevant? commit 413118ebf3162418639a5c4af14b02d26571a02c Author: Michael Felt Date: Fri Sep 14 01:35:56 2018 +0200 Fix test_asyncio for AIX - do not call transport.get_extra_info('sock

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

twisteroid ambassador added the comment: With regards to the failing test, it looks like the test basically boils down to testing whether loop.getaddrinfo('fe80::1%1', 80, type=socket.SOCK_STREAM) returns (, , *, *, ('fe80::1', 80, 0, 1)). This feels like a dangerous assumption to make, sinc

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

twisteroid ambassador added the comment: AFAIK the reason why scope id is required for IPv6 is that every IPv6 interfaces has its own link-local address, and all these addresses are in the same subnet, so without an additional scope id there’s no way to tell from which interface an address can b

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Michael Felt added the comment: On 22/05/2019 10:43, Michael Felt wrote: > 'fe80::1%1' <> 'fe80::1' - ... I am not 'experienced' with IPv6 and scope. >From what I have just read (again) - scope seems to be a way to indicate the interface used (e.g., eth0, or enp0s25) as a "number". Further, ge

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Michael Felt added the comment: from below: In case of 3.7 first call to _ensure_resolved returns ('fe80::1', 12345, 0, 1) then second call returns ('fe80::1', 12345, 0, 0) Notice that scope is now completely lost and is set to 0, thus actual call to socket.connect is wrong In case of 3.6 bo

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

miss-islington added the comment: New changeset 94704048e2467dbb4c53ca02d103eab5671e84b3 by Miss Islington (bot) in branch '3.7': bpo-35545: Fix asyncio discarding IPv6 scopes (GH-11271) https://github.com/python/cpython/commit/94704048e2467dbb4c53ca02d103eab5671e84b3 -- _

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Change by miss-islington : -- pull_requests: +13290 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

miss-islington added the comment: New changeset ac8eb8f36bf7ca636f8d886eb65a3b532f4725d5 by Miss Islington (bot) (Erwan Le Pape) in branch 'master': bpo-35545: Fix asyncio discarding IPv6 scopes (GH-11271) https://github.com/python/cpython/commit/ac8eb8f36bf7ca636f8d886eb65a3b532f4725d5 --

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

twisteroid ambassador added the comment: Oh wait, there's also this in asyncio docs for loop.sock_connect: Changed in version 3.5.2: address no longer needs to be resolved. sock_connect will try to check if the address is already resolved by calling socket.inet_pton(). If not, loop.getaddrin

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

twisteroid ambassador added the comment: I just noticed that in the socket module, an AF_INET address tuple is allowed to have an unresolved host name. Quote: A pair (host, port) is used for the AF_INET address family, where host is a string representing either a hostname in Internet domain

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

twisteroid ambassador added the comment: Hi Emmanuel, Are you referring to my PR 11403? I don't see where IPv6 uses separate parameters. -- ___ Python tracker ___ __

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Emmanuel Arias added the comment: Hi!, I was reading the PR. Just a little comment. I am not sure about have a difference for IPv4 and IPv6, in the sense of use a tuple for IPv4 and separate parameters for IPv6 Regards -- nosy: +eamanu ___ Pyt

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Change by twisteroid ambassador : -- pull_requests: +10786, 10787, 10788, 10789 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Change by twisteroid ambassador : -- pull_requests: +10786 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Change by twisteroid ambassador : -- pull_requests: +10786, 10787, 10788 ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Change by twisteroid ambassador : -- pull_requests: +10786, 10787 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

twisteroid ambassador added the comment: Also I believe it's a good idea to change the arguments of _ensure_resolved() from (address, *, ...) to (host, port, *, ...), and go through all its usages, making sure we're not mixing host + port with address tuples everywhere in asyncio. -

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

twisteroid ambassador added the comment: I think the root cause of this bug is a bit of confusion. The "customer-facing" asyncio API, create_connection(), takes two arguments: host and port. The lower-level API that actually deal with connecting sockets, socket.connect() and loop.sock_connec

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Change by Erwan Le Pape : -- keywords: +patch pull_requests: +10507 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-l

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

Erwan Le Pape added the comment: While the 3.7+ getaddrinfo isn't the best human representation of an IPv6 address, I believe it does make the most sense to keep it that way. In any case, this is a regression and changing return values of getaddrinfo for 3.7 isn't something that should be con

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

New submission from Максим Аристов : loop.create_connection doesn't handle ipv6 RFC4007 addresses right since 3.7 TEST CASE # Set up listener on link-local address fe80::1%lo sudo ip a add dev lo fe80::1 # 3.6 handles everything fine socat file:/dev/null tcp6-listen:12345,REUSEADDR & python3.