[issue3535] zipfile has problem reading zip files over 2GB

2008-09-05 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Fixed in r66240, r66241. Thanks! -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3535] zipfile has problem reading zip files over 2GB

2008-09-05 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: I also agree with the patch. This seems the correct way to detect the Zip64 format. -- nosy: +amaury.forgeotdarc ___ Python tracker <[EMAIL PROTECTED]>

[issue3535] zipfile has problem reading zip files over 2GB

2008-09-05 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- keywords: +needs review ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-lis

[issue3535] zipfile has problem reading zip files over 2GB

2008-09-05 Thread Alan McIntyre
Alan McIntyre <[EMAIL PROTECTED]> added the comment: No, I don't have commit access at the moment. ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3535] zipfile has problem reading zip files over 2GB

2008-09-05 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Alan, do you have commit access? Otherwise the patch needs approval from another core developer. ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3535] zipfile has problem reading zip files over 2GB

2008-09-05 Thread Alan McIntyre
Alan McIntyre <[EMAIL PROTECTED]> added the comment: Your patch seems like a better way to detect whether a file is written as Zip64, and it seems to be able to properly handle extracting a >2GB file from a >2GB archive, so I'd vote to include it. I tested it with r66233, using a file made fro

[issue3535] zipfile has problem reading zip files over 2GB

2008-09-05 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Alan, do you have an opinion on this? -- nosy: +alanmcintyre versions: +Python 2.7, Python 3.1 -Python 2.6, Python 3.0 ___ Python tracker <[EMAIL PROTECTED]>

[issue3535] zipfile has problem reading zip files over 2GB

2008-08-17 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Alon, can you try with the following patch? It seems to fix it here. -- keywords: +patch priority: -> normal versions: +Python 2.6, Python 3.0 -Python 2.5 Added file: http://bugs.python.org/file11137/largezip.patch _

[issue3535] zipfile has problem reading zip files over 2GB

2008-08-17 Thread alonwas
alonwas <[EMAIL PROTECTED]> added the comment: Antoine, I had a similar problem with zip version 2.32, but this is fixed in version 3.0 (or on 64-bit architectures). Would you be able to give it a try with the newer version (which can be obtained from info-zip.org)? Unfortunately, my upload bandw

[issue3535] zipfile has problem reading zip files over 2GB

2008-08-13 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > The problem happens for files between 2GB and 4GB. I can't really send > you a link to such a big file. To reproduce the problem, you can > generate one. The problem is that the "zip" command fails to create a zip file larger than 2GB (I ge

[issue3535] zipfile has problem reading zip files over 2GB

2008-08-12 Thread alonwas
alonwas <[EMAIL PROTECTED]> added the comment: Hi Antoine, The problem happens for files between 2GB and 4GB. I can't really send you a link to such a big file. To reproduce the problem, you can generate one. I created (and attach) a tiny C program that helps generate one. If you want to, you can

[issue3535] zipfile has problem reading zip files over 2GB

2008-08-11 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Do you have a public URL for such a zip file? -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3535] zipfile has problem reading zip files over 2GB

2008-08-11 Thread alonwas
alonwas <[EMAIL PROTECTED]> added the comment: Hi, I'm using 2.5.2 (r252:60911), Thanks, Alon On Sun, 2008-08-10 at 17:51 +, Martin v. Löwis wrote: > Martin v. Löwis <[EMAIL PROTECTED]> added the comment: > > What Python version exactly are you using? This might have been fixed in > 2.5.2,

[issue3535] zipfile has problem reading zip files over 2GB

2008-08-10 Thread Martin v. Löwis
Martin v. Löwis <[EMAIL PROTECTED]> added the comment: What Python version exactly are you using? This might have been fixed in 2.5.2, with r60117. -- nosy: +loewis ___ Python tracker <[EMAIL PROTECTED]>

[issue3535] zipfile has problem reading zip files over 2GB

2008-08-10 Thread alonwas
New submission from alonwas <[EMAIL PROTECTED]>: zipfile complains about "Bad magic number for central directory" when I give it files over 2GB. I believe the problem is that the offset for the central directory should be read as an unsigned long rather than as a signed long. Modifying structEndA