[issue35252] test_functools dead code after FIXME

2019-05-19 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue35252] test_functools dead code after FIXME

2019-05-19 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset d673810b9d9df6fbd29f5b7db3973d5adae10fd3 by Łukasz Langa (Lysandros Nikolaou) in branch 'master': bpo-35252: Remove FIXME from test_functools (GH-10551) https://github.com/python/cpython/commit/d673810b9d9df6fbd29f5b7db3973d5adae10fd3 --

[issue35252] test_functools dead code after FIXME

2019-05-17 Thread Cheryl Sabella
Cheryl Sabella added the comment: @lukasz.langa added this FIXME comment originally, so nosying him for a review. -- nosy: +cheryl.sabella, lukasz.langa ___ Python tracker ___

[issue35252] test_functools dead code after FIXME

2018-11-14 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: It actually seems like the test after the FIXME is wrong and should be changed or deleted altogether. Can someone give a pointer or two on what would be the best choice here? -- ___ Python tracker

[issue35252] test_functools dead code after FIXME

2018-11-14 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- keywords: +patch pull_requests: +9797 stage: -> patch review ___ Python tracker ___ ___ Python-bu

[issue35252] test_functools dead code after FIXME

2018-11-14 Thread Lysandros Nikolaou
New submission from Lysandros Nikolaou : In test_functools.TestSingleDispatch.test_invalid_registrations (https://github.com/python/cpython/blob/4c596d54aa6a55e9d2a3db78891e656ebbfb63c8/Lib/test/test_functools.py#L2299) there is a FIXME with an immediate return afterwards that says that the co