[issue34855] batch file variables

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue34855] batch file variables

miss-islington added the comment: New changeset 2bd5f7e91add6a20c311d46c332c4325b1e77883 by Miss Islington (bot) in branch '3.7': bpo-34855: Fix EXTERNALS_DIR build variable for Windows (GH-11177) https://github.com/python/cpython/commit/2bd5f7e91add6a20c311d46c332c4325b1e77883 -- n

[issue34855] batch file variables

Change by miss-islington : -- pull_requests: +11007, 11008, 11009 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue34855] batch file variables

Change by miss-islington : -- pull_requests: +11007, 11008 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue34855] batch file variables

Change by miss-islington : -- pull_requests: +11007 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue34855] batch file variables

Steve Dower added the comment: New changeset 6aedfa6b9ac324587f64133c23757a66a8f355bb by Steve Dower (antektek) in branch 'master': bpo-34855: Fix EXTERNALS_DIR build variable for Windows (GH-11177) https://github.com/python/cpython/commit/6aedfa6b9ac324587f64133c23757a66a8f355bb --

[issue34855] batch file variables

Steve Dower added the comment: They should set it, and it will be read in PCbuild/python.props which has the "correct" name (I forget what it is right now and am not looking it up on my phone) -- ___ Python tracker

[issue34855] batch file variables

Eric Lindblad added the comment: Should windows-steps.yml (line 11) and windows-appx-test.yml committed 6 Dec. (line 39) both read EXTERNALS_DIR? -- ___ Python tracker ___ __

[issue34855] batch file variables

Change by Anthony Blomme : -- keywords: +patch, patch pull_requests: +10546, 10547 stage: -> patch review ___ Python tracker ___ __

[issue34855] batch file variables

Change by Anthony Blomme : -- keywords: +patch pull_requests: +10546 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue34855] batch file variables

Steve Dower added the comment: Yep, good catch. That should be EXTERNALS_DIR in PCbuild/find_python.bat. -- components: +Windows keywords: +easy nosy: +paul.moore, steve.dower, tim.golden, zach.ware versions: +Python 3.6, Python 3.7 ___ Python track

[issue34855] batch file variables

New submission from Eric Lindblad : The development version code can set the variable EXTERNALS_DIR in two .bat files, but nowhere in a .bat file is set the variable EXTERNAL_DIR, the latter appearing in find_python.bat. I am not a Powershell user and so cannot interpret the content of the fi