[issue34844] logging.Formatter enhancement - Checking on style and fmt fields

Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue34844] logging.Formatter enhancement - Checking on style and fmt fields

Guido van Rossum added the comment: W00t! Congrats Luna and thanks for your contribution. Thanks Vinay for the prompt reviews! -- ___ Python tracker ___ _

[issue34844] logging.Formatter enhancement - Checking on style and fmt fields

Vinay Sajip added the comment: New changeset 18fb1fb943b7dbd7f8a76017ee2a67ef13effb85 by Vinay Sajip (BNMetrics) in branch 'master': bpo-34844: logging.Formatter enhancement - Ensure style and format string matches in logging.Formatter (GH-9703) https://github.com/python/cpython/commit/18fb

[issue34844] logging.Formatter enhancement - Checking on style and fmt fields

Vinay Sajip added the comment: I see a PR has been added, I'll start to review it after the CLA has been signed. -- ___ Python tracker ___ ___

[issue34844] logging.Formatter enhancement - Checking on style and fmt fields

Change by Luna Chen : -- keywords: +patch pull_requests: +9088 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list m

[issue34844] logging.Formatter enhancement - Checking on style and fmt fields

Luna Chen added the comment: Thank you Vinay! I think you have some good points! :) I'm going to make the following changes - re-raise the keyError into ValueError in XXXStyle.format - add validate() methods to XXXstyle class, and call them in logging.Formatter Best regards, Luna Chen --

[issue34844] logging.Formatter enhancement - Checking on style and fmt fields

Vinay Sajip added the comment: > Checking fmt to match the style in the constructor of logging.Formatter This seems a reasonable change to want to make. You would need to parse the format string for fields using the appropriate style. This should probably be via a validate() method in each o

[issue34844] logging.Formatter enhancement - Checking on style and fmt fields

Guido van Rossum added the comment: Moving to Python 3.8 because this is a feature proposal. Adding Vinay to nosy list because this is about logging. -- nosy: +vinay.sajip versions: +Python 3.8 -Python 3.6 ___ Python tracker

[issue34844] logging.Formatter enhancement - Checking on style and fmt fields

Change by Luna Chen : -- title: logging.Formatter enhancement - Checking on style and -> logging.Formatter enhancement - Checking on style and fmt fields ___ Python tracker __