[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Yury Selivanov
Yury Selivanov added the comment: Aaand... it's back. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Yury Selivanov
Yury Selivanov added the comment: Closing this now, please reopen if there's still no search bar in a few hours. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 581890cda36f60cd46185c6e184abe35a95813a2 by Yury Selivanov in branch '3.7': bpo-34733: Return of the docs search bar (GH-9431) https://github.com/python/cpython/commit/581890cda36f60cd46185c6e184abe35a95813a2 -- __

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Yury Selivanov
Yury Selivanov added the comment: > Does master and 3.7 branch build the docs at different times? It's odd to me > that master still shows the search box and 3.7 does not. layout.html was refactored in 3.8: scripts were moved into separate files. I accidentally copied it from 3.8 to 3.7, wh

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Yury Selivanov
Change by Yury Selivanov : -- keywords: +patch pull_requests: +8848 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-l

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Julien Palard
Julien Palard added the comment: Thanks Yuri (and thanks for the rewrite!) -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Carol Willing
Carol Willing added the comment: Does master and 3.7 branch build the docs at different times? It's odd to me that master still shows the search box and 3.7 does not. I'm getting on a flight soon. Yury would be a good person to ping re: changing. -- _

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Yury Selivanov
Yury Selivanov added the comment: Oh, this is a result of asyncio docs 3.8 -> 3.7 backport. I'll fix this. -- ___ Python tracker ___ __

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Julien Palard
Change by Julien Palard : -- nosy: +yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Julien Palard
Julien Palard added the comment: Yes, got it too : 512d7101098b971837cbb406942215244f636547, they literally removed the searchbox: $ git show 512d7101098b971837cbb406942215244f636547 | grep searchbox -{%- macro searchbox() %} -{# modified from sphinx/themes/basic/searchbox.html #} -{{

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Carol Willing
Carol Willing added the comment: @mdk The asyncio folks did make a change to the layout in https://github.com/python/cpython/pull/9364 . It's a bit weird that 3.7 is the release that is missing the search bar. -- ___ Python tracker

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Julien Palard
Julien Palard added the comment: I got it back by building with 90f7d455b (7 days ago), so I'm git bisecting... -- ___ Python tracker ___ _

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Julien Palard
Julien Palard added the comment: I can reproduce it locally [1]. The Python logo at the left dissapear to, it goes from "[LOGO] Python »" to "3.7.0 Documentation »". Did not spotted recent changes in the theme / docsbuild-scripts / cpython/Doc for the moment, but now I can inspect locally. L

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Carol Willing
Carol Willing added the comment: Confirming that I see the same behavior as reported by @xtreak. -- nosy: +willingc stage: -> needs patch versions: +Python 3.7 ___ Python tracker ___

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Ned Deily
Change by Ned Deily : -- nosy: +mdk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/m

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Strange it's present on both 3.8.a0 and for 3.6.6 but not for 3.7.0 Thanks -- nosy: +xtreak ___ Python tracker ___ ___

[issue34733] Missing search bar on docs.python.org

2018-09-19 Thread Harrison Chudleigh
New submission from Harrison Chudleigh : The search bar is missing from docs.python.org, probably as a result of a minor error in the webpage. This is a quite recent change, as the search bar is still there in a web.archive.org snapshot from the 13th of September (last week). Could someone p