[issue34715] timemodule.c fails to compile on BSD

Benjamin Peterson added the comment: New changeset c510c6b8b60f211793e0b84c317ea6974e8a6153 by Benjamin Peterson in branch 'master': Simplify PyInit_timezone. (GH-9467) https://github.com/python/cpython/commit/c510c6b8b60f211793e0b84c317ea6974e8a6153 --

[issue34715] timemodule.c fails to compile on BSD

Change by Benjamin Peterson : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue34715] timemodule.c fails to compile on BSD

Change by Benjamin Peterson : -- pull_requests: +8880 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue34715] timemodule.c fails to compile on BSD

STINNER Victor added the comment: New changeset 1fb399ba4e977e697d194769070316247237f68e by Victor Stinner in branch 'master': bpo-34715: Revert "Simplify PyInit_timezone. (GH-9323)" (GH-9366) https://github.com/python/cpython/commit/1fb399ba4e977e697d194769070316247237f68e --

[issue34715] timemodule.c fails to compile on BSD

STINNER Victor added the comment: I wrote PR 9366 to fix the compilation of timemodule.c on FreeBSD. -- nosy: +vstinner ___ Python tracker ___

[issue34715] timemodule.c fails to compile on BSD

Change by STINNER Victor : -- keywords: +patch pull_requests: +8790 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-l

[issue34715] timemodule.c fails to compile on BSD

Change by Pablo Galindo Salgado : -- nosy: +p-ganssle ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue34715] timemodule.c fails to compile on BSD

Pablo Galindo Salgado added the comment: Reverting afde1c1a05c and 5633c4f342d fixes the issue. -- nosy: -p-ganssle ___ Python tracker ___ ___

[issue34715] timemodule.c fails to compile on BSD

Change by Paul Ganssle : -- nosy: +p-ganssle ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue34715] timemodule.c fails to compile on BSD

Change by Pablo Galindo Salgado : -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34715] timemodule.c fails to compile on BSD

Pablo Galindo Salgado added the comment: Bisecting returns commit 5633c4f342d as possible culprit -- ___ Python tracker ___ ___ Pyt

[issue34715] timemodule.c fails to compile on BSD

New submission from Pablo Galindo Salgado : Example: https://buildbot.python.org/all/#/builders/87/builds/1434 ./Modules/timemodule.c:573:24: warning: assigning to 'char *' from 'const char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers] p->tm_zone = PyUn